woocommerce / woocommerce-ios

WooCommerce iOS app
https://www.woocommerce.com/mobile
GNU General Public License v2.0
299 stars 110 forks source link

[Woo POS] Add new SwiftUI implementation of payment message UI #13071

Closed joshheald closed 1 month ago

joshheald commented 3 months ago

Now that payment messages will be shown inline, we should implement that UI instead of a modal alert.

These will generally be simple views, but in the case of errors, they do need to show buttons. We don't yet have final designs for these error states, but can use our best judgement for now.

Please note – most of these already have Views and all have ViewModels for the new POS – see:

States

*: These messages have cancel buttons when shown modally in the existing app implementation. Does cancelling the payment make sense with the inl-ine presentation, especially with no option to pay by cash?

What should happen to the order after they cancel the payment? @joe-keenan, your thoughts here would be appreciated... but happy to chat about it sync if that would help.

Perhaps, to allow people to cancel a payment and use a different card (especially from errors) we should show the cancel button. Once cancellation is done, we can prepare the reader to take payment again, as we do when we first show the Totals/Checkout screen

dangermattic commented 3 months ago

Thanks for reporting! 👍

joshheald commented 3 months ago

Blocked while awaiting designs especially for errors

bozidarsevo commented 3 months ago

@joshheald is it ok for me to take this task as we discussed regarding the UI changes?

joshheald commented 3 months ago

@bozidarsevo Of course 😊

@malinajirka is going to set up a new project for the UI work anyway, so this is in a new sub-project now.

bozidarsevo commented 1 month ago

I suppose we can close this one since we pretty much separated parts of this into different issues?

staskus commented 1 month ago

@bozidarsevo, I think so. @joshheald, can we close this?

joshheald commented 1 month ago

Yes, the remaining checkboxes should all be picked up in #13481.