[Woo POS] M2: Handle product edge cases

woocommerce / woocommerce-ios

WooCommerce iOS app

https://www.woocommerce.com/mobile

GNU General Public License v2.0

300 stars 110 forks source link

[Woo POS] M2: Handle product edge cases #13243

Closed iamgabrielma closed 4 weeks ago

iamgabrielma commented 2 months ago

The current limitation is to use simple physical products only, but there's some other criteria within simple products that we should test and take into account. For example:

Products without price should be non eligible
What price we'll be showing when a product has:
- price
- regularPrice
- salePrice
What if purchasable is false? Should be eligible or not?
soldIndividually? Part of a bundle? etc, ...

dangermattic commented 2 months ago

Thanks for reporting! 👍

iamgabrielma commented 1 month ago

P2: pdfdoF-5d5-p2

joshheald commented 4 weeks ago

Is this done with #13503 @iamgabrielma ? I don't think it is, but they're in the same area so wanted to check.

iamgabrielma commented 4 weeks ago

Thanks for following up. I'll close this one: The main changes regarding eligibility were done on https://github.com/woocommerce/woocommerce-ios/pull/13503, and https://github.com/woocommerce/woocommerce-ios/pull/13522. The remaining item for the different prices has been logged as low priority on https://github.com/woocommerce/woocommerce-ios/issues/13502