[Woo POS] Consider updating CollectOrderPaymentUseCase for the existing app behavior that transforms a retryable payment error to non-retryable after the first retry fails

woocommerce / woocommerce-ios

WooCommerce iOS app

https://www.woocommerce.com/mobile

GNU General Public License v2.0

299 stars 110 forks source link

[Woo POS] Consider updating CollectOrderPaymentUseCase for the existing app behavior that transforms a retryable payment error to non-retryable after the first retry fails #13326

Open malinajirka opened 1 month ago

malinajirka commented 1 month ago

Ref: p1718735478831209/1718734994.548519-slack-C070SJRA8DP

I'm not sure that the existing behaviour of transforming a retryable error to a non-retryable error, the after the first retry fails, is the right approach. If the error comes up and says "try another card", but they try the same card, you do actually want them to be able to try again, not have to start over. Changing this means changing the existing code, but it's probably something we should consider a bug in the existing code.

dangermattic commented 1 month ago

🚫 Please add a type label (e.g. type: enhancement) and a feature label (e.g. feature: stats) to this issue.

malinajirka commented 1 month ago

I agree with Jaclyn that this is a bug in the existing code => the Android app doesn't behave this way, it fully relies on the Stripe SDK to tell us whether an error is retryable or not and I believe the iOS app should behave the same.