search

woocommerce / woocommerce-ios

WooCommerce iOS app
https://www.woocommerce.com/mobile
GNU General Public License v2.0
301 stars 109 forks source link

[Woo POS] Reader modal should dismiss after connected state changes in Totals View #13663

Open staskus opened 2 months ago

staskus commented 2 months ago

Describe the bug

Feedback: p91TBi-bYt-p2#comment-12903

On the iOS Errors video there is a flash where the modal closes but the error is still showing. We need to reverse that so the error goes away and then the modal closes.

https://github.com/user-attachments/assets/a1ec9b37-2ea8-4f27-87b1-601875cc25ec

Considerations

We may be only seeing a slight delay since totals view animates transitions.

To Reproduce Steps to reproduce the behavior:

  1. Open POS
  2. Add a product
  3. Check out
  4. Connect reader
  5. Notice when reader modal dismisses, totals view transitions into connected state

Expected behavior A clear and concise description of what you expected to happen.

Isolating the problem (mark completed items with an [x]):

Mobile Environment Please include:

WordPress Environment

``` Copy and paste the system status report from **WooCommerce > System Status** in WordPress admin. ```
dangermattic commented 2 months ago

Thanks for reporting! 👍

joshheald commented 2 months ago

As described, and with our existing code, this will require an artificial delay before we dismiss the connection modal, and even that is likely to take a while to implement.

Showing the connection modals at all is a intermediate point on the road to the preferred design. My understanding is that we'd like them to show in-line in this context, i.e. where the "Connect your reader" error is right now. That would make this a non-issue.

I'm hesitant to spend a long time on this for a relatively infrequent flow, but we could potentially add a new in-line screen that shows behind the connection modals once we start connecting to a reader with Connecting .... If the connection fails or gets cancelled, we'd have to go back to the Reader disconnected view here, after all.

staskus commented 2 months ago

Thanks for taking a look 👍

we could potentially add a new in-line screen that shows behind the connection modals once we start connecting to a reader with Connecting ...

If we are to do something about this, it does sound like a good idea. Although I'm hesitant to spend much time on this as well. It's good to gather feedback but we could leave it with a lower-priority for now.