woocommerce / woocommerce-ios

WooCommerce iOS app
https://www.woocommerce.com/mobile
GNU General Public License v2.0
300 stars 110 forks source link

[Woo POS] Improvement to the "no internet connection" notification #13743

Open iamgabrielma opened 2 weeks ago

iamgabrielma commented 2 weeks ago

The existing "no internet connection" notification doesn't work properly when detecting if connection has been recovered, which leads to the notification still showing up despite having internet connection.

Simulator Screenshot - iPad Pro (12 9-inch) (6th generation) - 2024-08-27 at 10 07 18

A potential improvement could be to add tappable behaviour to the notification: If tapped, we can directly check if there's connection, rather than relying on observing the reachability state.

This fits Apple's recommendation of "do not attempt to guess whether network service is available, and do not cache that determination [...] The SCNetworkReachability API is not intended for use as a preflight mechanism for determining network connectivity. You determine network connectivity by attempting to connect."

To replicate:

dangermattic commented 2 weeks ago

🚫 Please add a type label (e.g. type: enhancement) and a feature label (e.g. feature: stats) to this issue.