search

woocommerce / woocommerce-ios

WooCommerce iOS app
https://www.woocommerce.com/mobile
GNU General Public License v2.0
309 stars 110 forks source link

[Woo POS] Pagination UI improvement: Update animation on pull-to-refresh #14251

Open iamgabrielma opened 1 week ago

iamgabrielma commented 1 week ago

From review on https://github.com/woocommerce/woocommerce-ios/pull/14226#pullrequestreview-2401010336

during pull-to-refresh, the product list view along with its scroll indicator seems to move around

https://github.com/user-attachments/assets/e3354e15-2e8c-4897-a738-b079799a64f6

This most likely comes from not considering any specific animation when the state changes to .loading, as now we're just performing an easeInOut for .isInitialLoading on PointOfSaleDashboardView: 

.animation(.easeInOut, value: viewModel.isInitialLoading)

The spinner is overlapping with the fading non-simple products notice briefly

Since the banner is temporary and seems to be going away with the new design iteration, let's keep this in the backlog for now.

dangermattic commented 1 week ago

Thanks for reporting! 👍