woocommerce / woocommerce-ios

WooCommerce iOS app
https://www.woocommerce.com/mobile
GNU General Public License v2.0
314 stars 113 forks source link

[Woo POS] Fix stores without the supported country/currency can still access POS #14383

Closed jaclync closed 1 week ago

jaclync commented 1 week ago

Closes: #14367

Why

When the POS payments onboarding feature flag is enabled, the site checks (country and currency) function isn't invoked because it's currently under the onboarding state publisher. Therefore, stores with unsupported country/currency can still access POS when the onboarding feature flag is enabled (false in production, so the issue isn't expected to affect production users).

How

First, test cases were added/updated so that the new cases with the payments onboarding feature flag fail without any changes. Then, the site checks are included as a filter on the returned published whenever the WC version or the remote feature flag changes.

Steps to reproduce

Testing information


Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

wpmobilebot commented 1 week ago

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr14383-1f02e51
Version21.1
Bundle IDcom.automattic.alpha.woocommerce
Commit1f02e51a4a700ddfe2dd72ee9cdad1ea5ac5b31e
App Center BuildWooCommerce - Prototype Builds #11531

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.