Closed joshheald closed 1 week ago
1 Warning | |
---|---|
:warning: | View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity. |
Generated by :no_entry_sign: Danger
📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.
App Name | WooCommerce iOS | |
Build Number | pr14389-c12316f | |
Version | 21.1 | |
Bundle ID | com.automattic.alpha.woocommerce | |
Commit | c12316f6dbddcf020ff17b46a92f0514327e48cf | |
App Center Build | WooCommerce - Prototype Builds #11543 |
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.
Description
This PR updates the ItemList to get the POSModel from the environment, as part of the architectural changes.
The view models still need it passed in, but they won’t be around for too long with the future architectural changes.
Testing information
At the moment this only has implications for the ItemList; you can simply check that CI passes and that the app doesn't crash when we get to the ItemListView (which would happen if we didn't inject the posModel into the environment from the entry view.
I've tested on an iPad Air running iOS 17.7
RELEASE-NOTES.txt
if necessary.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: