[Shipping labels] Add Yosemite support for getting list of packages

bozidarsevo commented 1 week ago

Closes: #13553

Description

Added networking support for getting packages using the latest plugin endpoint.
Support is mostly added with additions to WooShippingAction and WooShippingStore

Looks like the endpoint is currently not supported.

Testing information

For now the new action isn't yet used in the app, so confirm unit tests pass.

[x] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

[ ] The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
[ ] Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
[ ] Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

dangermattic commented 1 week ago

	1 Warning
:warning:	This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by :no_entry_sign: Danger

wpmobilebot commented 1 week ago

📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce iOS
	Build Number	pr14403-ea6411f
	Version	21.1
	Bundle ID	com.automattic.alpha.woocommerce
	Commit	ea6411f4938c6ebb696dac1a3ef3260d289df30d
	App Center Build	WooCommerce - Prototype Builds #11612

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

rachelmcr commented 1 week ago

Before we go ahead with these changes, I think we should double check with the extension team about the documented endpoint. I expected that this request would include all the required details about all predefined packages (not just the ID, and not just the saved/activated options). I expected something similar to the sample response from the legacy endpoint.

Otherwise, we don't have any endpoint that provides those details to display the carrier packages in the UI.

rachelmcr commented 1 week ago

We could also ask the team for a build of the extension that includes this endpoint support, so we can test it and generate mock responses to use for WooShippingRemoteTests, to test how our mapper decodes the response.

rachelmcr commented 1 week ago

i went ahead and raised the question/concern about the data in this response here: p1731499656158269-slack-C05VBLKHHV1

woocommerce / woocommerce-ios