search

woocommerce / woocommerce-ios

WooCommerce iOS app
https://www.woocommerce.com/mobile
GNU General Public License v2.0
314 stars 113 forks source link

Handle PaymentGatewayAccountError when logged in with site credentials #14409

Open joshheald opened 1 week ago

joshheald commented 1 week ago

Description

There are various places in our code where we have special-case handling for DotcomError instances coming from a network request.

These may be used to give specific resolution advice to the users.

When logged in with site credentials, the networking stack will return NetworkError instances instead, and any specific resolution is unlikely to be shown.

We should check these areas, and if needed, handle the NetworkError as well.

Note that it might be best to do the error unwrapping in Yosemite, and return a specific error type to the app layer, so that we don't need to import these networking error types in the WooCommerce target.

Context: peaMlT-Zl-p2

Area to check

Relates to

14410

14374

14365

dangermattic commented 1 week ago

🚫 Please add a type label (e.g. type: enhancement) and a feature label (e.g. feature: stats) to this issue.