There are various places in our code where we have special-case handling for DotcomError instances coming from a network request.
These may be used to give specific resolution advice to the users.
When logged in with site credentials, the networking stack will return NetworkError instances instead, and any specific resolution is unlikely to be shown.
We should check these areas, and if needed, handle the NetworkError as well.
Note that it might be best to do the error unwrapping in Yosemite, and return a specific error type to the app layer, so that we don't need to import these networking error types in the WooCommerce target.
Context: peaMlT-Zl-p2
Areas to check
ProductStore.synchronizeProducts (products API request error from invalid product type due to lack of extensions on the site.)
dangermattic
commented
1 week ago
Description
There are various places in our code where we have special-case handling for
DotcomErrorinstances coming from a network request.These may be used to give specific resolution advice to the users.
When logged in with site credentials, the networking stack will return
NetworkErrorinstances instead, and any specific resolution is unlikely to be shown.We should check these areas, and if needed, handle the
NetworkErroras well.Note that it might be best to do the error unwrapping in Yosemite, and return a specific error type to the app layer, so that we don't need to import these networking error types in the WooCommerce target.
Context: peaMlT-Zl-p2
Areas to check
ProductStore.synchronizeProducts(products API request error from invalid product type due to lack of extensions on the site.)ProductStore ProductUpdateError initProductCategoryStore.synchronizeProductCategory categoryDoesNotExistRemotelyRelates to
14409
14374
14365