[Woo POS] Remove `displayInfiniteScrollingUIDetailsInPointOfSale` flag

iamgabrielma commented 1 week ago

Part of https://github.com/woocommerce/woocommerce-ios/issues/14186

Description

We remove the feature flag displayInfiniteScrollingUIDetailsInPointOfSale to hide/display the GhostItemCardView, which was added as 21.1 beta fix.

Testing information

On release build configuration, load the POS and observe that the GhostItemCardView appears when state is loading (waiting for items from the remote).

Screenshots

https://github.com/user-attachments/assets/12dfcdff-a627-470b-83f8-e11ef0e35b4a

[x] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

[x] The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
[x] Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
[x] Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

wpmobilebot commented 1 week ago

📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce iOS
	Build Number	pr14413-e1aa1bc
	Version	21.1
	Bundle ID	com.automattic.alpha.woocommerce
	Commit	e1aa1bc1ff1bdf09c529f9427578346406599878
	App Center Build	WooCommerce - Prototype Builds #11590

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

iamgabrielma commented 4 days ago

Thanks for the review!

the ghost cell gets wonky at big dynamic type sizes

Nice catch. Logged: https://github.com/woocommerce/woocommerce-ios/issues/14443

woocommerce / woocommerce-ios