woocommerce / woocommerce-ios

WooCommerce iOS app
https://www.woocommerce.com/mobile
GNU General Public License v2.0
314 stars 113 forks source link

Rename "deposit" to "payout" in code and documentation URL #14415

Closed jaclync closed 4 days ago

jaclync commented 1 week ago

Closes: #14369

Description

After this PR, there should be minimal mentions of "deposit" in the app with the exceptions in the Networking layer and Tracks event names.

Steps to reproduce

Testing information

Screenshots


Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

dangermattic commented 1 week ago
1 Warning
:warning: This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
1 Message
:book:

This PR contains changes to Tracks-related logic. Please ensure (author and reviewer) the following are completed:

  • The tracks events must be validated in the Tracks system.
  • Verify the internal Tracks spreadsheet has also been updated.
  • Please consider registering any new events.
  • The PR must be assigned the category: tracks label.

Generated by :no_entry_sign: Danger

wpmobilebot commented 1 week ago

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr14415-5cb3585
Version21.1
Bundle IDcom.automattic.alpha.woocommerce
Commit5cb3585f305e0f4b8d8a1a325461219f8200e7e0
App Center BuildWooCommerce - Prototype Builds #11602

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

jaclync commented 1 week ago

Note for reviewer: Danger CI step requires the PR to have a category: tracks label due to some diffs on the analytics code, but the diffs are only from renaming the variables/constants without affecting the values.

staskus commented 1 week ago

the doc content still refers to "deposit" at the moment, but the URL should be using "payout" in the path

✅ Already updated!

image