Closed jaclync closed 4 days ago
1 Warning | |
---|---|
:warning: | This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews. |
1 Message | |
---|---|
:book: | This PR contains changes to Tracks-related logic. Please ensure (author and reviewer) the following are completed:
|
Generated by :no_entry_sign: Danger
📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.
App Name | WooCommerce iOS | |
Build Number | pr14415-5cb3585 | |
Version | 21.1 | |
Bundle ID | com.automattic.alpha.woocommerce | |
Commit | 5cb3585f305e0f4b8d8a1a325461219f8200e7e0 | |
App Center Build | WooCommerce - Prototype Builds #11602 |
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.
Note for reviewer: Danger CI step requires the PR to have a category: tracks
label due to some diffs on the analytics code, but the diffs are only from renaming the variables/constants without affecting the values.
the doc content still refers to "deposit" at the moment, but the URL should be using "payout" in the path
✅ Already updated!
Closes: #14369
Description
https://woocommerce.com/document/woopayments/deposits/deposit-schedule/
tohttps://woocommerce.com/document/woopayments/payouts/payout-schedule/
(the previous URL already redirects to the new one in production).WooPaymentsPayoutsOverview
if manual naming mapping isn't implemented). I didn't rename the simulated network response JSON files because the API path is still using "deposit" (confirmation about the API path/schema renaming plan in paJDYF-e8c-p2#comment-26973)After this PR, there should be minimal mentions of "deposit" in the app with the exceptions in the Networking layer and Tracks event names.
Steps to reproduce
Testing information
Screenshots
RELEASE-NOTES.txt
if necessary.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: