[Shipping Labels] Get account settings setup

bozidarsevo commented 2 days ago

Closes: #13558

Description

Networking support got GET account settings endpoint
Added loadAccountSettings action in WooShippingAction
WooShippingAccountSettingsResponse contains ShippingLabelStoreOptions and ShippingLabelAccountSettings since that is the data we get in GET account settings request response
Updated tests to accommodate the changes, especially in WooShippingRemoteTests to test the response json parsing/mapping

Testing information

For now the new action isn't yet used in the app, so confirm unit tests pass.

[x] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

[x] The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
[x] Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
[x] Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

wpmobilebot commented 2 days ago

📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce iOS
	Build Number	pr14455-3e92c18
	Version	21.1
	Bundle ID	com.automattic.alpha.woocommerce
	Commit	3e92c186822f682d4634fd2fe5614bfb57457a0e
	App Center Build	WooCommerce - Prototype Builds #11711

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

dangermattic commented 2 days ago

	1 Warning
:warning:	This PR is assigned to the milestone 21.2. This milestone is due in less than 2 days. Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by :no_entry_sign: Danger

bozidarsevo commented 22 hours ago

Also, could you make sure we're using this new endpoint in the UI layer?

You mean for adding the packages UI? The packages endpoint has the storeOptions so I will use the storeOptions from that response there. That is why I did not use this response data anywhere, I wanted to add the support for it and then we can use it where needed in UI.

rachelmcr commented 21 hours ago

You mean for adding the packages UI? The packages endpoint has the storeOptions so I will use the storeOptions from that response there.

Good to know! We'll also need to update the account settings (used in various places like checking if the user can manage the label payment method or setting the default label paper size for printing). Some of that can be done in later milestones but some will be needed for this milestone. Could you open an issue for checking where it needs to be used in the UI, so we can work on that separately?

bozidarsevo commented 20 hours ago

Could you open an issue for checking where it needs to be used in the UI, so we can work on that separately?

Created! https://github.com/woocommerce/woocommerce-ios/issues/14484 I think I will jump on that tomorrow so we have that covered

woocommerce / woocommerce-ios