woocommerce / woocommerce-ios

WooCommerce iOS app
https://www.woocommerce.com/mobile
GNU General Public License v2.0
314 stars 113 forks source link

[Woo POS] Extract onboarding to aggregate model #14456

Closed joshheald closed 1 day ago

joshheald commented 2 days ago

Closes: #14452

Description

This PR moves onboarding to the new Aggregate Model.

Testing information

I haven't tested every single onboarding state; the logic is simply moved, but otherwise unchanged, so it didn't seem neccesary to test every possible state.

I've gone through a new store flow as shown in the video below. It's very long! Everything worked as expected, however I'm not sure whether keeping it in a non-fullscreen sheet is the best when using WP-Admin. On the other hand... it's never going to be a good experience doing it in a web view.

The most important things to check are:

Screenshots

https://github.com/user-attachments/assets/e652aec1-18ef-478f-8afe-acd37e5a0370


Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

wpmobilebot commented 2 days ago

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr14456-0b1e3b8
Version21.1
Bundle IDcom.automattic.alpha.woocommerce
Commit0b1e3b84024eec945644dc98fd26f8510a69cfa6
App Center BuildWooCommerce - Prototype Builds #11655

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.