woocommerce / woocommerce-ios

WooCommerce iOS app
https://www.woocommerce.com/mobile
GNU General Public License v2.0
314 stars 113 forks source link

[Woo POS] [Cash & Receipts] Feature flag & button render for sending POS receipts #14463

Closed iamgabrielma closed 2 days ago

iamgabrielma commented 2 days ago

Closes: #14460

Description

We add the feature flag for .sendReceiptsForPointOfSale as well as the initial "Receipt" button after a successful card-present payment purchase via POS. The flag is turned off by default, so changes don't show either in release nor in debug builds, as the button is still not functional.

Steps to reproduce

  1. Load POS, go through the purchase flow, and observe that there is no new button rendered at the end. Simulator Screenshot - iPad Air 11 - iOS 17 5 M2 - 2024-11-20 at 12 42 55

  2. Set .sendReceiptsForPointOfSale to true, go through the same purchase flow, and observe the button is now present (but not functional)

Light Dark
Simulator Screenshot - iPad Air 11 - iOS 17 5 M2 - 2024-11-20 at 12 35 44 Simulator Screenshot - iPad Air 11 - iOS 17 5 M2 - 2024-11-20 at 12 36 01

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

wpmobilebot commented 2 days ago

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr14463-7ff0778
Version21.1
Bundle IDcom.automattic.alpha.woocommerce
Commit7ff07781c35de703898b0bb34fa4c100aa4d8f5b
App Center BuildWooCommerce - Prototype Builds #11662

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

dangermattic commented 2 days ago
1 Warning
:warning: This PR is assigned to the milestone 21.2. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by :no_entry_sign: Danger