[REST API] Jetpack Setup: Tracks for account creation + enable the feature

hichamboushaba commented 1 day ago

Closes: #14468

Description

This PR updates tracking for Jetpack setup to allow tracking signup flow, it adds a new property is_signup to the magic link step events.

The PR also enables the feature and removes the feature flag.

Test magic link for both login and signup flow, and confirm the is_signup property is properly tracked.

[x] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

[ ] The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
[ ] Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
[ ] Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

dangermattic commented 1 day ago

	2 Warnings
:warning:	View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.
:warning:	This PR is assigned to the milestone 21.2. This milestone is due in less than 2 days. Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by :no_entry_sign: Danger

wpmobilebot commented 1 day ago

📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce iOS
	Build Number	pr14471-b57a6b9
	Version	21.1
	Bundle ID	com.automattic.alpha.woocommerce
	Commit	b57a6b955ac664ada51196e80e8d315fdeb0b640
	App Center Build	WooCommerce - Prototype Builds #11707

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.