woocommerce / woocommerce-ios

WooCommerce iOS app
https://www.woocommerce.com/mobile
GNU General Public License v2.0
314 stars 113 forks source link

Update Ruby Gems for the latest release-toolkit version #14487

Open irfano opened 17 hours ago

irfano commented 17 hours ago

Description

This only updates gems. The purpose is using the latest release-toolkit version.

Testing information

It seems safe to me not to test anything, but let me know if I missed anything, @iangmaia.


Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

wpmobilebot commented 6 hours ago

Version 21.2 has now entered code-freeze, so the milestone of this PR has been updated to 21.3.

hafizrahman commented 6 hours ago

After the PR was approved, I saw a build error that says `Podfile.lock was changed by bundle exec pod install. Please run bundle exec pod install locally with a clean cache and commit the result."

I did as it said and pushed in https://github.com/woocommerce/woocommerce-ios/pull/14487/commits/3ada1876f710c2a55b54afbfb434ec83f94db848

wpmobilebot commented 6 hours ago

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr14487-3ada187
Version21.1
Bundle IDcom.automattic.alpha.woocommerce
Commit3ada1876f710c2a55b54afbfb434ec83f94db848
App Center BuildWooCommerce - Prototype Builds #11720

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

dangermattic commented 2 hours ago
1 Error
:no_entry_sign: This PR is tagged with status: do not merge label(s).

Generated by :no_entry_sign: Danger

hafizrahman commented 2 hours ago

This is good to go but I'm setting "do not merge" for now. We want to put it into release 21.2 so we can test screenshots generation in release. I'm not sure what's the next steps are here as we're just in code freeze @selanthiraiyan

selanthiraiyan commented 1 hour ago

Thanks, @irfano for working on this!

This is good to go but I'm setting "do not merge" for now. We want to put it into release 21.2 so we can test screenshots generation in release. I'm not sure what's the next steps are here as we're just in code freeze @selanthiraiyan

@hafizrahman This PR and the next one here https://github.com/woocommerce/woocommerce-ios/pull/14492 look good to me to merge as beta fixes into the release branch. Will that be all, or do we need to make further changes?