woocommerce / woocommerce-ios

WooCommerce iOS app
https://www.woocommerce.com/mobile
GNU General Public License v2.0
298 stars 110 forks source link

Add-ons: add-on details are missing from the order details screens #4271

Closed designsimply closed 3 years ago

designsimply commented 3 years ago

To prepare:

  1. Have a site with Product Add-ons installed.
  2. On the web, create a new order including an add-on.
  3. In the app, go to Settings > Experimental Features and toggle the order add-ons switch on.
  4. Close and re-open the app.

To test:

  1. Go to orders > mark the order as complete or put it on hold, and tap "Details" under the products section.
  2. Look for add-on information on the order details product list screen.

Result: orders containing products with add-ons applied to no show add-on information on the order details screen. (2m52s)

Order Order > Products > Details View Add-Ons Web-view of the same order
Screen Shot 2021-05-24 at May 24 7 11 57 PM Screen Shot 2021-05-24 at May 24 6 54 04 PM Screen Shot 2021-05-24 at May 24 6 53 55 PM Screen Shot 2021-05-24 at May 24 6 56 43 PM

Note: this happened for me regardless of whether the order contained add-on products grouped or not.

Order Order > Product > Details View Add-Ons Web-view of the same order
IMG_4145 IMG_4147 IMG_4146 Screen Shot 2021-05-24 at May 24 7 18 40 PM

(internal reference: p5T066-2iC-p2#comment-8307 /ht @astralbodies)

Mobile Environment

WordPress Environment

``` ### WordPress Environment ### WordPress address (URL): https://double-reef.jurassic.ninja Site address (URL): https://double-reef.jurassic.ninja WC Version: 5.3.0 REST API Version: ✔ 5.3.0 WC Blocks Version: ✔ 4.9.1 Action Scheduler Version: ✔ 3.1.6 WC Admin Version: ✔ 2.2.6 Log Directory Writable: ✔ WP Version: ❌ 5.7.2 - There is a newer version of WordPress available (5.7.3-alpha-50937) WP Multisite: – WP Memory Limit: 256 MB WP Debug Mode: ✔ WP Cron: ✔ Language: en_US External object cache: – ### Server Environment ### Server Info: Apache/2.4.46 (Unix) OpenSSL/1.0.2g PHP Version: 7.4.18 PHP Post Max Size: 1 GB PHP Time Limit: 30 PHP Max Input Vars: 5000 cURL Version: 7.47.0 OpenSSL/1.0.2g SUHOSIN Installed: – MySQL Version: 5.7.33-0ubuntu0.16.04.1-log Max Upload Size: 512 MB Default Timezone is UTC: ✔ fsockopen/cURL: ✔ SoapClient: ✔ DOMDocument: ✔ GZip: ✔ Multibyte String: ✔ Remote Post: ✔ Remote Get: ✔ ### Database ### WC Database Version: 5.3.0 WC Database Prefix: wp_ Total Database Size: 13.03MB Database Data Size: 10.02MB Database Index Size: 3.01MB wp_woocommerce_sessions: Data: 0.03MB + Index: 0.02MB + Engine InnoDB wp_woocommerce_api_keys: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_woocommerce_attribute_taxonomies: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_woocommerce_downloadable_product_permissions: Data: 0.02MB + Index: 0.06MB + Engine InnoDB wp_woocommerce_order_items: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_woocommerce_order_itemmeta: Data: 0.08MB + Index: 0.09MB + Engine InnoDB wp_woocommerce_tax_rates: Data: 0.02MB + Index: 0.06MB + Engine InnoDB wp_woocommerce_tax_rate_locations: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_woocommerce_shipping_zones: Data: 0.02MB + Index: 0.00MB + Engine InnoDB wp_woocommerce_shipping_zone_locations: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_woocommerce_shipping_zone_methods: Data: 0.02MB + Index: 0.00MB + Engine InnoDB wp_woocommerce_payment_tokens: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_woocommerce_payment_tokenmeta: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_woocommerce_log: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_actionscheduler_actions: Data: 0.03MB + Index: 0.11MB + Engine InnoDB wp_actionscheduler_claims: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_actionscheduler_groups: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_actionscheduler_logs: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_ce4wp_abandoned_checkout: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_commentmeta: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_comments: Data: 0.05MB + Index: 0.09MB + Engine InnoDB wp_links: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_mailchimp_carts: Data: 0.02MB + Index: 0.00MB + Engine InnoDB wp_mailchimp_jobs: Data: 0.02MB + Index: 0.00MB + Engine InnoDB wp_mailpoet_custom_fields: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_mailpoet_dynamic_segment_filters: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_mailpoet_feature_flags: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_mailpoet_forms: Data: 0.02MB + Index: 0.00MB + Engine InnoDB wp_mailpoet_log: Data: 0.02MB + Index: 0.00MB + Engine InnoDB wp_mailpoet_mapping_to_external_entities: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_mailpoet_newsletters: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_mailpoet_newsletter_links: Data: 0.02MB + Index: 0.05MB + Engine InnoDB wp_mailpoet_newsletter_option: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_mailpoet_newsletter_option_fields: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_mailpoet_newsletter_posts: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_mailpoet_newsletter_segment: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_mailpoet_newsletter_templates: Data: 2.52MB + Index: 0.00MB + Engine InnoDB wp_mailpoet_scheduled_tasks: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_mailpoet_scheduled_task_subscribers: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_mailpoet_segments: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_mailpoet_sending_queues: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_mailpoet_settings: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_mailpoet_statistics_clicks: Data: 0.02MB + Index: 0.05MB + Engine InnoDB wp_mailpoet_statistics_forms: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_mailpoet_statistics_newsletters: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_mailpoet_statistics_opens: Data: 0.02MB + Index: 0.08MB + Engine InnoDB wp_mailpoet_statistics_unsubscribes: Data: 0.02MB + Index: 0.05MB + Engine InnoDB wp_mailpoet_statistics_woocommerce_purchases: Data: 0.02MB + Index: 0.06MB + Engine InnoDB wp_mailpoet_stats_notifications: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_mailpoet_subscribers: Data: 0.02MB + Index: 0.13MB + Engine InnoDB wp_mailpoet_subscriber_custom_field: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_mailpoet_subscriber_ips: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_mailpoet_subscriber_segment: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_mailpoet_user_flags: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_options: Data: 4.11MB + Index: 0.19MB + Engine InnoDB wp_postmeta: Data: 1.52MB + Index: 0.48MB + Engine InnoDB wp_posts: Data: 0.25MB + Index: 0.09MB + Engine InnoDB wp_termmeta: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_terms: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_term_relationships: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_term_taxonomy: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_usermeta: Data: 0.06MB + Index: 0.03MB + Engine InnoDB wp_users: Data: 0.02MB + Index: 0.05MB + Engine InnoDB wp_wc_admin_notes: Data: 0.02MB + Index: 0.00MB + Engine InnoDB wp_wc_admin_note_actions: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_wc_category_lookup: Data: 0.02MB + Index: 0.00MB + Engine InnoDB wp_wc_customer_lookup: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_wc_download_log: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_wc_order_coupon_lookup: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_wc_order_product_lookup: Data: 0.02MB + Index: 0.06MB + Engine InnoDB wp_wc_order_stats: Data: 0.02MB + Index: 0.05MB + Engine InnoDB wp_wc_order_tax_lookup: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_wc_product_meta_lookup: Data: 0.05MB + Index: 0.09MB + Engine InnoDB wp_wc_reserved_stock: Data: 0.02MB + Index: 0.00MB + Engine InnoDB wp_wc_tax_rate_classes: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_wc_webhooks: Data: 0.02MB + Index: 0.02MB + Engine InnoDB ### Post Type Counts ### attachment: 54 global_product_addon: 1 mailpoet_page: 1 nav_menu_item: 102 page: 21 post: 40 product: 16 product_variation: 220 shop_order: 24 shop_order_refund: 2 ### Security ### Secure connection (HTTPS): ✔ Hide errors from visitors: ❌Error messages should not be shown to visitors. ### Active Plugins (13) ### Companion Plugin: by Osk – 1.18 Creative Mail by Constant Contact: by Constant Contact – 1.3.8 Facebook for WooCommerce: by Facebook – 2.5.0 Jetpack by WordPress.com: by Automattic – 9.7 Google Ads & Marketing by Kliken: by Kliken – 1.0.7 MailPoet 3 (New): by MailPoet – 3.61.0 WooCommerce Smooth Generator: by Automattic – 1.0.1 WCS staging: by mb – 1.0 WooCommerce Payments: by Automattic – 2.4.0 WooCommerce Product Add-ons: by WooCommerce – 4.0.0 WooCommerce Shipping & Tax: by WooCommerce – 1.25.13 WooCommerce: by Automattic – 5.3.0 WordPress Beta Tester: by Peter Westwood Andy Fragen – 3.1.0 ### Inactive Plugins (1) ### Akismet Anti-Spam: by Automattic – 4.1.9 ### Settings ### API Enabled: – Force SSL: – Currency: USD ($) Currency Position: left Thousand Separator: , Decimal Separator: . Number of Decimals: 2 Taxonomies: Product Types: external (external) grouped (grouped) simple (simple) variable (variable) Taxonomies: Product Visibility: exclude-from-catalog (exclude-from-catalog) exclude-from-search (exclude-from-search) featured (featured) outofstock (outofstock) rated-1 (rated-1) rated-2 (rated-2) rated-3 (rated-3) rated-4 (rated-4) rated-5 (rated-5) Connected to WooCommerce.com: – ### WC Pages ### Shop base: #1364 - /shop/ Cart: #1365 - /cart/ Checkout: #1366 - /checkout/ My account: #1367 - /my-account/ Terms and conditions: ❌ Page not set ### Theme ### Name: Storefront Version: 3.6.0 Author URL: https://woocommerce.com/ Child Theme: ❌ – If you are modifying WooCommerce on a parent theme that you did not build personally we recommend using a child theme. See: How to create a child theme WooCommerce Support: ✔ ### Templates ### Overrides: – ### Action Scheduler ### Complete: 62 Oldest: 2021-05-17 21:37:45 +0000 Newest: 2021-05-25 00:25:19 +0000 ### Status report information ### Generated at: 2021-05-25 00:43:14 +00:00 ```
Ecarrion commented 3 years ago

Hi @designsimply! I'm not totally sure I understand the bug.

Is it that when you mark the order as "complete" and then tap on details you see a list of products but no information about their add-ons?

If that is the case, I think that would be a feature request!

Also, what would you want to see there? The "view add-ons" button? or all the product attributes information?

cc @adamzelinski

designsimply commented 3 years ago

As a user, I expect to be able to see all the details for the products in an order to be available on any details-related screens for the order.

For example, in Order 1651, I ordered 1 test product with a Gift Wrapping add-on and 1 test product with an Engraving add-on. Here's how the order looked on the web when I placed it:

Screen Shot 2021-05-25 at May 25 10 42 59 AM

In the app, when I check the order while the status is on hold or completed, the main order screen shows 2 test products and mentions gift wrapping but not the engraving:

IMG_4151

When I tap View Add-Ons, I can see one charge for gift wrapping but the detail about the engraving add-on is missing:

IMG_4153

When I tap Details, I can see that 2 test products were ordered but there is not any information about add-ons at all:

IMG_4152

In Order 1651, I cannot tell at all that one of the test products has an engraving add-on and I think that's a bug. It's possible this may be covered by the grouped products by different add-ons issue https://github.com/woocommerce/woocommerce-ios/issues/4126, however, some add-on details only ever show up on the main order screen.

For example, in Order 1653, I ordered one product with an engraving add-on, and no "View Add-on" option is presented and the Details screen also doesn't mention engraving or that the order has any add-ons:

IMG_4156 IMG_4157

Am I thinking about Details incorrectly? Is that really a summary product list and details are not expected there? Why isn't "View Add-on" presented on the order screen for a product with a text field add-on?

Ecarrion commented 3 years ago

Hi @designsimply

Any issue related to an order that has two of the same products will be fixed by #4126. Unfortunately we are blocked by p91TBi-566-p2#comment-4513


I will also make sure that the "view add-ons" button is visible no matter what status the order has.


For

For example, in Order 1653, I ordered one product with an engraving add-on, and no "View Add-on" option is presented and the Details screen also doesn't mention engraving or that the order has any add-ons:

Screen Shot 2021-05-25 at 4 14 50 PM

For the order product detail screen, I missed covering that case. @adamzelinski what do you think we should do there? Should we show a "view add-on" button in that cell or is it enough with the "view add-ons" button from the order detail screen?

ghost commented 3 years ago

For the order product detail screen, I missed covering that case. @adamzelinski what do you think we should do there? Should we show a "view add-on" button in that cell or is it enough with the "view add-ons" button from the order detail screen?

I think for what was in scope with the workaround we could just show the 'view add-ons' button here thanks @Ecarrion

Ecarrion commented 3 years ago

Hi @designsimply,

Regarding the issue where orders with on-hold status weren't showing the "view add-ons" button. Could you confirm that you had the beta-feature enabled?

I just tested it using your credentials and I can see the "view add-on" button correctly!

Screen Shot 2021-05-26 at 5 17 41 PM
designsimply commented 3 years ago

Regarding the issue where orders with on-hold status weren't showing the "view add-ons" button. Could you confirm that you had the beta-feature enabled?

@Ecarrion, my apologies, let me try to clarify. I could see the "View Add-Ons" button on orders where products were not grouped, like in order 1653. Where I could not see the engraving add-on was in an order with grouped products that had different add-ons, such as in order 1651.

Here's how order 1651 looks in my WP Admin:

image

And here's how the same order 1651 looks in the app right now after I double checked that the experimental feature toggle is on:

Engraving is never mentioned, however, I think this is part of the grouped items issue that will be fixed as part of #4126 so I can help re-test this after we're able to get a fix for the grouping issue.

Ecarrion commented 3 years ago

Hey @designsimply! Oh ok, there is no issue with the status of the order. As you mention #4126 will fix all the issues where items are grouped.

Also, #4293 adds the "View Add-on" button in the product detail screen. SO I think this can be closed now!