woocommerce / woocommerce-ios

WooCommerce iOS app
https://www.woocommerce.com/mobile
GNU General Public License v2.0
302 stars 109 forks source link

Design: Some views using UIViewControllerRepresentable have extra safe area insets #6592

Open rachelmcr opened 2 years ago

rachelmcr commented 2 years ago

Describe the bug

UIKit view controllers wrapped in UIViewControllerRepresentable views to use in SwiftUI have safe area insets added to them. This can create extra, unwanted padding (most notably in landscape) for those views. The most straightforward way I found to deal with this is to add .ignoresSafeArea() to the view in the SwiftUI layout.

Affected views:

Settings

SettingsView

In-Person Payments

InPersonPayments

Reviews

Reviews

Survey

Survey

Share Sheet

ShareSheet

peril-woocommerce[bot] commented 2 years ago
Fails
:no_entry_sign: Please add a feature label to this issue. e.g. 'feature: stats'

Generated by :no_entry_sign: dangerJS