Add test for WPConsentAPI class. - Githubissues

woocommerce / woocommerce-order-source-attribution

WooCommerce Order Source Attribution helps merchants understand which marketing activities, channels or campaigns are leading to orders in their stores.

https://github.com/woocommerce/woocommerce-order-source-attribution

5 stars 0 forks source link

Add test for WPConsentAPI class. #23

Closed rawdreeg closed 1 year ago

rawdreeg commented 1 year ago

Testing the WPConsentAPI class. I made the following changes:

is_wp_consent_api_active is no longer static to simplify the testing.
added the wc_order_source_attribution_allow_tracking filter. We talked about controlling the tracking (https://github.com/woocommerce/woocommerce-order-source-attribution/issues/6) from 3rd party plugin. This should help with that.

Checks:

[ x] Does your code follow the WordPress coding standards?

Detailed test instructions:

composer install
bin/install-unit-tests.sh <db-name> <db-user> <db-pass> [db-host] latest latest
vendor/bin/phpunit
The testing steps outlined in #13 should still pass.

budzanowski commented 1 year ago

Left some small notes, nothing blocking really. Approving.

rawdreeg commented 1 year ago

@budzanowski , thanks for the review. I have addressed all the feedback. do you mind having another look?