Preserve subscription renewal processing when switching Subscriptions Mode or disabling gateway (680)

[Dinamiko]

1. When either Vaulting or the gateway is disabled, renewal payments for existing subscriptions will not process correctly.
2. When the Subscriptions Mode setting in PayPal gateway is not configured the same way as an active subscription, it will fail to renew.

Steps To Reproduce

1.1 PayPal gateway disabled

• PayPal gateway enabled and Subscriptions Mode Vaulting
• Purchase subscription
• Disable PayPal gateway
• Run renewal action manually from Scheduled Actions as currently no action in Order Actions is displayed when PayPal gateway is disabled.
  • “An error has occurred while processing a recent subscription related event…” is displayed in Scheduled Actions screen
  • Renewal Order is not created in the subscription
  • Order note “Unable to change subscription status to “on-hold”.

1.2 ACDC gateway disabled

• ACDC gateway enabled and Subscriptions Mode Vaulting
• Purchase subscription
• Disable ACDC gateway
• Run renewal action manually from Scheduled Actions as currently no action in Order Actions is displayed when PayPal gateway is disabled.
  • “An error has occurred while processing a recent subscription related event…” is displayed in Scheduled Actions screen
  • Renewal Order is not created in the subscription
  • Order note “Unable to change subscription status to “on-hold”.

2.1 Subscription Mode switch from PayPal Vaulting to PayPal Subscriptions

• PayPal gateway enabled and Subscriptions Mode PayPal Vaulting
• Purchase subscription
• Switch Subscriptions Mode to PayPal Subscriptions
• Trigger renewal manually from subscription
  • This seems to work just fine, renewal order created correctly.

2.2 Subscription Mode switch from PayPal Subscriptions to PayPal Vaulting

• PayPal gateway enabled and Subscriptions Mode PayPal Subscriptions

• Purchase PayPal subscription (create and connect if it does not exist)

• Renewal subscription by sending PayPal PAYMENT.SALE.COMPLETED webhook manually (using Postman or cURL…):

  • Define constant to disable webhook verification (ex. in custom plugin):

  ! defined( 'PAYPAL_WEBHOOK_REQUEST_VERIFICATION' ) && define( 'PAYPAL_WEBHOOK_REQUEST_VERIFICATION', false );

  • Go to the subscription and copy ppcp_subscription from Custom Fields, use this value as billing_agreement_id.

  POST http://example.com/wp-json/paypal/v1/incoming
  {
      "id": "I-DONT-CARE",
      "event_type": "PAYMENT.SALE.COMPLETED",
      "resource": {
          "billing_agreement_id": "I-ABC123",
          "id": "I-DONT-CARE-EITHER"
      }
  }

• Switch Subscriptions Mode to PayPal Vaulting

• Renewal subscription again

  • This seems to work just fine, renewal order created correctly.

2.3 Subscription Mode switch from PayPal Vaulting to Disable PayPal for subscriptions

• PayPal gateway enabled and Subscriptions Mode Vaulting
• Purchase subscription
• Switch Subscription Mode from PayPal Vaulting to Disable PayPal for subscriptions
• Run renewal action manually from Scheduled Actions as currently no action in Order Actions is displayed when PayPal gateway is disabled.
  • “An error has occurred while processing a recent subscription related event…” is displayed in Scheduled Actions screen
  • Renewal Order is not created in the subscription
  • Order note “Unable to change subscription status to “on-hold”.

Possible Cause

1. No WC Subscriptions support is added when PayPal gateway is disabled. Same happens for Credit card gateway.

Suggested solution

1. Do not conditionally add gateway support based on gateway settings.

Acceptance Criteria

• Ensure you can switch settings and does not break existing subscriptions renewal.
• Now you can run manual renewals (only for vaulted subscriptions) from the subscription Order Actions even if the gateway setting is disabled.
• Ensure no related subscriptions (Vaulting and PayPal Subscriptions) functionality is broken by the new changes.