search

woocommerce / woocommerce-product-recommendations-custom-locations

Use WordPress shortcodes to display product recommendations at any page or location of your WooCommerce store. Feature plugin for the official Product Recommendations extension.
3 stars 1 forks source link

Update dev dependencies and fix broken build #10

Closed mattsherman closed 2 months ago

mattsherman commented 2 months ago

Description

This PR updates the dev dependencies and build scripts, allowing this project to be successfully built in the same dev environment as other extensions such as the base WooCommerce Product Recommendations.

Closes #9

Changes included

Testing instructions

On a system with WooCommerce Product Recommendations installed...

  1. Clone repo
  2. Run npm i - verify dependencies are installed without error (used to complain about missing python2)
  3. Run grunt build - verify build completes without error
  4. Activate plugin
  5. Go to WooCommerce > Recommendations > Custom Locations
  6. Add a custom location.
  7. Edit the custom location and verify that the styling and functionality is correct... key points...
    • Shortcode meta box styling
    • Copy shortcode feature should work
  8. Verify the following files were requested without error (if the above points in (7) are fine, this will be the case, but just to double-check!):
    • assets/css/admin/wc-prl-cl-admin.css
    • assets/js/admin/wc-prl-cl-admin.js
Screenshot 2024-08-26 at 16 08 00
mattsherman commented 2 months ago

Tested and reviewed the code. Was able to build and run the extension successfully.

Thanks!

I think you need to add the issue to a milestone. Can you please do that?

Done (this public repo didn't have any milestones, but there is no reason to not start using them! 😄)

mattsherman commented 2 months ago

Looking good, @mattsherman! Nice catch on the unused prop!

Before approving, how about adding a similar .nvmrc file as well?

Great idea -- done in d8685c7!