search

woocommerce / woocommerce-product-tables-feature-plugin

Implements new data-stores and moves product data into custom tables, with a new, normalised data structure.
GNU General Public License v3.0
193 stars 32 forks source link

Cannot set featured image on regular blog posts #166

Open bhaal2 opened 4 years ago

bhaal2 commented 4 years ago

I've narrowed it down to being this plugin which is blocking me from setting feature images on regular blog posts which are not part of a product etc. Haven't figured out why yet though.

EDIT: Seems there is no test to see whether it's a post or a product before updating (haven't tested it during post creation) _thumbnail_id

bhaal2 commented 4 years ago

Potentially crude, and I haven't tested to see what else breaks, but for now changing the following line: if ( ! isset( $mapping[ $meta_key ] ) ) { To: if ( ! isset( $mapping[ $meta_key ] ) || get_post_type($post_id) == "post") { for get, add, update, and delete filters in class-wc-product-tables-backwards-compatibility.php seems to have fixed it.. And the _thumbnail_id also now shows up on the public side.

Soo, a bug, and I doubt this is the proper fix, but hopefully it helps get the ball rolling. And no, even if this is the right fix, I don't know enough about git in order to fork, and setup a pull request for this..