woocommerce / woocommerce-product-tables-feature-plugin

Implements new data-stores and moves product data into custom tables, with a new, normalised data structure.
GNU General Public License v3.0
193 stars 32 forks source link

Fix test WC_Tests_Product_Functions::test_wc_get_product_ids_on_sale() #81

Closed rodrigoprimo closed 6 years ago

rodrigoprimo commented 6 years ago

This test is failing with the following error message:

8) WC_Tests_Product_Functions::test_wc_get_product_ids_on_sale
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
+    0 => 660
+    1 => 670
+    2 => 0

wp-content/plugins/woocommerce/tests/unit-tests/product/functions.php:515

This test passes if you run it alone using vendor/bin/phpunit --filter test_wc_get_product_ids_on_sale, so this is an indication that maybe we need to update it to be isolated from the rest of the tests.

rodrigoprimo commented 6 years ago

Fixed by https://github.com/woocommerce/woocommerce/commit/920006b8b93658d28a13ecb88750bffff8dd8584