woocommerce / woocommerce-sniffs

Collection of PHP_CodeSniffer sniffs for WooCommerce
https://packagist.org/packages/woocommerce/woocommerce-sniffs
MIT License
48 stars 10 forks source link

Update dependency dealerdirect/phpcodesniffer-composer-installer to v1 - abandoned #33

Closed renovate[bot] closed 1 year ago

renovate[bot] commented 1 year ago

Mend Renovate

This PR contains the following updates:

Package Type Update Change
dealerdirect/phpcodesniffer-composer-installer (source) require major ^0.7.0 -> ^1.0.0

Release Notes

PHPCSStandards/composer-installer ### [`v1.0.0`](https://togithub.com/PHPCSStandards/composer-installer/releases/tag/v1.0.0) [Compare Source](https://togithub.com/PHPCSStandards/composer-installer/compare/v0.7.2...v1.0.0) #### Breaking changes - Rename namespace prefix from `Dealerdirect` to `PHPCSStandards` by [@​jrfnl](https://togithub.com/jrfnl) in [https://github.com/PHPCSStandards/composer-installer/pull/191](https://togithub.com/PHPCSStandards/composer-installer/pull/191) - Drop support for PHP 5.3 by [@​jrfnl](https://togithub.com/jrfnl) in [https://github.com/PHPCSStandards/composer-installer/pull/147](https://togithub.com/PHPCSStandards/composer-installer/pull/147) #### What's Changed - Correct grammar in error message by [@​fredden](https://togithub.com/fredden) in [https://github.com/PHPCSStandards/composer-installer/pull/189](https://togithub.com/PHPCSStandards/composer-installer/pull/189) - .gitattributes: sync with current repo state by [@​jrfnl](https://togithub.com/jrfnl) in [https://github.com/PHPCSStandards/composer-installer/pull/198](https://togithub.com/PHPCSStandards/composer-installer/pull/198) - PHPCSVersions: update URL references by [@​jrfnl](https://togithub.com/jrfnl) in [https://github.com/PHPCSStandards/composer-installer/pull/161](https://togithub.com/PHPCSStandards/composer-installer/pull/161) - Plugin: improve feedback by [@​jrfnl](https://togithub.com/jrfnl) in [https://github.com/PHPCSStandards/composer-installer/pull/182](https://togithub.com/PHPCSStandards/composer-installer/pull/182) - README: remove references to Scrutinizer by [@​jrfnl](https://togithub.com/jrfnl) in [https://github.com/PHPCSStandards/composer-installer/pull/157](https://togithub.com/PHPCSStandards/composer-installer/pull/157) - Rename references to `master` branch by [@​Potherca](https://togithub.com/Potherca) in [https://github.com/PHPCSStandards/composer-installer/pull/201](https://togithub.com/PHPCSStandards/composer-installer/pull/201) - Update repo references by [@​jrfnl](https://togithub.com/jrfnl) in [https://github.com/PHPCSStandards/composer-installer/pull/158](https://togithub.com/PHPCSStandards/composer-installer/pull/158) ##### CI / CD - GH Actions: add builds against Composer 2.2 for PHP 7.2 - 8.x by [@​jrfnl](https://togithub.com/jrfnl) in [https://github.com/PHPCSStandards/composer-installer/pull/172](https://togithub.com/PHPCSStandards/composer-installer/pull/172) - GH Actions: bust the cache semi-regularly by [@​jrfnl](https://togithub.com/jrfnl) in [https://github.com/PHPCSStandards/composer-installer/pull/192](https://togithub.com/PHPCSStandards/composer-installer/pull/192) - GH Actions: fix builds on Windows with PHP 8.2 by [@​jrfnl](https://togithub.com/jrfnl) in [https://github.com/PHPCSStandards/composer-installer/pull/180](https://togithub.com/PHPCSStandards/composer-installer/pull/180) - GH Actions: fix up fail-fast for setup-php by [@​jrfnl](https://togithub.com/jrfnl) in [https://github.com/PHPCSStandards/composer-installer/pull/195](https://togithub.com/PHPCSStandards/composer-installer/pull/195) - GH Actions: run integration tests against Composer snapshot by [@​jrfnl](https://togithub.com/jrfnl) in [https://github.com/PHPCSStandards/composer-installer/pull/163](https://togithub.com/PHPCSStandards/composer-installer/pull/163) - GH Actions: run linting against against ubuntu-latest by [@​jrfnl](https://togithub.com/jrfnl) in [https://github.com/PHPCSStandards/composer-installer/pull/184](https://togithub.com/PHPCSStandards/composer-installer/pull/184) - GH Actions/Securitycheck: update the security checker download by [@​jrfnl](https://togithub.com/jrfnl) in [https://github.com/PHPCSStandards/composer-installer/pull/178](https://togithub.com/PHPCSStandards/composer-installer/pull/178) - GH Actions/Securitycheck: update the security checker download by [@​jrfnl](https://togithub.com/jrfnl) in [https://github.com/PHPCSStandards/composer-installer/pull/186](https://togithub.com/PHPCSStandards/composer-installer/pull/186) - GH Actions/Securitycheck: update the security checker download by [@​jrfnl](https://togithub.com/jrfnl) in [https://github.com/PHPCSStandards/composer-installer/pull/190](https://togithub.com/PHPCSStandards/composer-installer/pull/190) - GH Actions: selectively use `fail-fast` with setup-php by [@​jrfnl](https://togithub.com/jrfnl) in [https://github.com/PHPCSStandards/composer-installer/pull/194](https://togithub.com/PHPCSStandards/composer-installer/pull/194) - GH Actions: stop running tests against PHP 5.5/Composer 1.x on Windows (and remove work-arounds) by [@​jrfnl](https://togithub.com/jrfnl) in [https://github.com/PHPCSStandards/composer-installer/pull/183](https://togithub.com/PHPCSStandards/composer-installer/pull/183) - GH Actions: various tweaks / PHP 8.2 not allowed to fail by [@​jrfnl](https://togithub.com/jrfnl) in [https://github.com/PHPCSStandards/composer-installer/pull/193](https://togithub.com/PHPCSStandards/composer-installer/pull/193) - GH Actions: version update for various predefined actions by [@​jrfnl](https://togithub.com/jrfnl) in [https://github.com/PHPCSStandards/composer-installer/pull/170](https://togithub.com/PHPCSStandards/composer-installer/pull/170) - Update YamLint by [@​Potherca](https://togithub.com/Potherca) in [https://github.com/PHPCSStandards/composer-installer/pull/173](https://togithub.com/PHPCSStandards/composer-installer/pull/173) ##### Tests - Add initial integration test setup and first few tests by [@​jrfnl](https://togithub.com/jrfnl) in [https://github.com/PHPCSStandards/composer-installer/pull/153](https://togithub.com/PHPCSStandards/composer-installer/pull/153) - BaseLineTest: stabilize the message checks by [@​jrfnl](https://togithub.com/jrfnl) in [https://github.com/PHPCSStandards/composer-installer/pull/162](https://togithub.com/PHPCSStandards/composer-installer/pull/162) - PlayNiceWithScriptsTest: wrap output expectation in condition by [@​jrfnl](https://togithub.com/jrfnl) in [https://github.com/PHPCSStandards/composer-installer/pull/179](https://togithub.com/PHPCSStandards/composer-installer/pull/179) - RegisterExternalStandardsTest: add new tests by [@​jrfnl](https://togithub.com/jrfnl) in [https://github.com/PHPCSStandards/composer-installer/pull/165](https://togithub.com/PHPCSStandards/composer-installer/pull/165) - RegisterExternalStandardsTest: stabilize test for Composer v1 on Windows with PHP 5.5 by [@​jrfnl](https://togithub.com/jrfnl) in [https://github.com/PHPCSStandards/composer-installer/pull/171](https://togithub.com/PHPCSStandards/composer-installer/pull/171) - TestCase::executeCliCommand(): retry Composer commands on a particular exception by [@​jrfnl](https://togithub.com/jrfnl) in [https://github.com/PHPCSStandards/composer-installer/pull/164](https://togithub.com/PHPCSStandards/composer-installer/pull/164) - Tests: add new `InstalledPathsOrderTest` by [@​jrfnl](https://togithub.com/jrfnl) in [https://github.com/PHPCSStandards/composer-installer/pull/176](https://togithub.com/PHPCSStandards/composer-installer/pull/176) - Tests: add new InstallUpdateEventsTest and NonInstallUpdateEventsTest by [@​jrfnl](https://togithub.com/jrfnl) in [https://github.com/PHPCSStandards/composer-installer/pull/174](https://togithub.com/PHPCSStandards/composer-installer/pull/174) - Tests: add new `InvalidPackagesTest` by [@​jrfnl](https://togithub.com/jrfnl) in [https://github.com/PHPCSStandards/composer-installer/pull/168](https://togithub.com/PHPCSStandards/composer-installer/pull/168) - Tests: add new `PlayNiceWithScriptsTest` by [@​jrfnl](https://togithub.com/jrfnl) in [https://github.com/PHPCSStandards/composer-installer/pull/169](https://togithub.com/PHPCSStandards/composer-installer/pull/169) - Tests: add new `PreexistingPHPCSConfigTest` by [@​jrfnl](https://togithub.com/jrfnl) in [https://github.com/PHPCSStandards/composer-installer/pull/166](https://togithub.com/PHPCSStandards/composer-installer/pull/166) - Tests: add new `PreexistingPHPCSInstalledPathsConfigTest` + bug fix by [@​jrfnl](https://togithub.com/jrfnl) in [https://github.com/PHPCSStandards/composer-installer/pull/167](https://togithub.com/PHPCSStandards/composer-installer/pull/167) - Tests: add new `RemovePluginTest` by [@​jrfnl](https://togithub.com/jrfnl) in [https://github.com/PHPCSStandards/composer-installer/pull/177](https://togithub.com/PHPCSStandards/composer-installer/pull/177) - Tests: add new RootPackageHandlingTest + bugfix by [@​jrfnl](https://togithub.com/jrfnl) in [https://github.com/PHPCSStandards/composer-installer/pull/175](https://togithub.com/PHPCSStandards/composer-installer/pull/175) #### New Contributors - [@​fredden](https://togithub.com/fredden) made their first contribution in [https://github.com/PHPCSStandards/composer-installer/pull/189](https://togithub.com/PHPCSStandards/composer-installer/pull/189) **Full Changelog**: https://github.com/PHPCSStandards/composer-installer/compare/v0.7.2...v1.0.0 ### [`v0.7.2`](https://togithub.com/PHPCSStandards/composer-installer/releases/tag/v0.7.2) [Compare Source](https://togithub.com/PHPCSStandards/composer-installer/compare/v0.7.1...v0.7.2) #### What's Changed - Add details regarding QA automation in CONTRIBUTING.md file. by [@​Potherca](https://togithub.com/Potherca) in [https://github.com/PHPCSStandards/composer-installer/pull/133](https://togithub.com/PHPCSStandards/composer-installer/pull/133) - Add mention of Composer and PHP compatibility to project README. by [@​Potherca](https://togithub.com/Potherca) in [https://github.com/PHPCSStandards/composer-installer/pull/132](https://togithub.com/PHPCSStandards/composer-installer/pull/132) - Composer: tweak PHPCS version constraint by [@​jrfnl](https://togithub.com/jrfnl) in [https://github.com/PHPCSStandards/composer-installer/pull/152](https://togithub.com/PHPCSStandards/composer-installer/pull/152) - CONTRIBUTING: remove duplicate code of conduct by [@​jrfnl](https://togithub.com/jrfnl) in [https://github.com/PHPCSStandards/composer-installer/pull/148](https://togithub.com/PHPCSStandards/composer-installer/pull/148) - Document release process by [@​Potherca](https://togithub.com/Potherca) in [https://github.com/PHPCSStandards/composer-installer/pull/118](https://togithub.com/PHPCSStandards/composer-installer/pull/118) - Plugin::loadInstalledPaths(): `config-show` always shows all by [@​jrfnl](https://togithub.com/jrfnl) in [https://github.com/PHPCSStandards/composer-installer/pull/154](https://togithub.com/PHPCSStandards/composer-installer/pull/154) - README: minor tweaks by [@​jrfnl](https://togithub.com/jrfnl) in [https://github.com/PHPCSStandards/composer-installer/pull/149](https://togithub.com/PHPCSStandards/composer-installer/pull/149) - README: update with information about Composer >= 2.2 by [@​jrfnl](https://togithub.com/jrfnl) in [https://github.com/PHPCSStandards/composer-installer/pull/141](https://togithub.com/PHPCSStandards/composer-installer/pull/141) - Replace deprecated Sensiolabs security checker by [@​paras-malhotra](https://togithub.com/paras-malhotra) in [https://github.com/PHPCSStandards/composer-installer/pull/130](https://togithub.com/PHPCSStandards/composer-installer/pull/130) - Stabilize a condition by [@​jrfnl](https://togithub.com/jrfnl) in [https://github.com/PHPCSStandards/composer-installer/pull/127](https://togithub.com/PHPCSStandards/composer-installer/pull/127) - Update copyright year by [@​jrfnl](https://togithub.com/jrfnl) in [https://github.com/PHPCSStandards/composer-installer/pull/138](https://togithub.com/PHPCSStandards/composer-installer/pull/138) - Various minor tweaks by [@​jrfnl](https://togithub.com/jrfnl) in [https://github.com/PHPCSStandards/composer-installer/pull/151](https://togithub.com/PHPCSStandards/composer-installer/pull/151) ##### CI/CD - Change YamlLint config to prevent "truthy" warning. by [@​Potherca](https://togithub.com/Potherca) in [https://github.com/PHPCSStandards/composer-installer/pull/144](https://togithub.com/PHPCSStandards/composer-installer/pull/144) - GH Actions: PHP 8.1 has been released by [@​jrfnl](https://togithub.com/jrfnl) in [https://github.com/PHPCSStandards/composer-installer/pull/139](https://togithub.com/PHPCSStandards/composer-installer/pull/139) - Travis: line length tweaks by [@​jrfnl](https://togithub.com/jrfnl) in [https://github.com/PHPCSStandards/composer-installer/pull/128](https://togithub.com/PHPCSStandards/composer-installer/pull/128) - CI: Switch to GH Actions by [@​jrfnl](https://togithub.com/jrfnl) in [https://github.com/PHPCSStandards/composer-installer/pull/137](https://togithub.com/PHPCSStandards/composer-installer/pull/137) - CI: various updates by [@​jrfnl](https://togithub.com/jrfnl) in [https://github.com/PHPCSStandards/composer-installer/pull/140](https://togithub.com/PHPCSStandards/composer-installer/pull/140) #### New Contributors - [@​paras-malhotra](https://togithub.com/paras-malhotra) made their first contribution in [https://github.com/PHPCSStandards/composer-installer/pull/130](https://togithub.com/PHPCSStandards/composer-installer/pull/130) **Full Changelog**: https://github.com/PHPCSStandards/composer-installer/compare/v0.7.1...v0.7.2 ### [`v0.7.1`](https://togithub.com/PHPCSStandards/composer-installer/releases/tag/v0.7.1) [Compare Source](https://togithub.com/PHPCSStandards/composer-installer/compare/v0.7.0...v0.7.1) #### What's Changed - Fixed v4 constraint by [@​GrahamCampbell](https://togithub.com/GrahamCampbell) in [https://github.com/PHPCSStandards/composer-installer/pull/115](https://togithub.com/PHPCSStandards/composer-installer/pull/115) - Update code of conduct by [@​Potherca](https://togithub.com/Potherca) in [https://github.com/PHPCSStandards/composer-installer/pull/117](https://togithub.com/PHPCSStandards/composer-installer/pull/117) - Add remark configuration by [@​Potherca](https://togithub.com/Potherca) in [https://github.com/PHPCSStandards/composer-installer/pull/122](https://togithub.com/PHPCSStandards/composer-installer/pull/122) - Travis: add build against PHP 8.0 by [@​jrfnl](https://togithub.com/jrfnl) in [https://github.com/PHPCSStandards/composer-installer/pull/124](https://togithub.com/PHPCSStandards/composer-installer/pull/124) - Sort list of installed paths before saving for consistency by [@​kevinfodness](https://togithub.com/kevinfodness) in [https://github.com/PHPCSStandards/composer-installer/pull/126](https://togithub.com/PHPCSStandards/composer-installer/pull/126) - Order of `installed_paths` inconsistent between runs [#​125](https://togithub.com/PHPCSStandards/composer-installer/issues/125) - Maintaining this project and Admin rights [#​113](https://togithub.com/PHPCSStandards/composer-installer/issues/113) #### New Contributors - [@​GrahamCampbell](https://togithub.com/GrahamCampbell) made their first contribution in [https://github.com/PHPCSStandards/composer-installer/pull/115](https://togithub.com/PHPCSStandards/composer-installer/pull/115) - [@​kevinfodness](https://togithub.com/kevinfodness) made their first contribution in [https://github.com/PHPCSStandards/composer-installer/pull/126](https://togithub.com/PHPCSStandards/composer-installer/pull/126) **Full Changelog**: https://github.com/PHPCSStandards/composer-installer/compare/v0.7.0...v0.7.1

Configuration

πŸ“… Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

β™» Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

πŸ”• Ignore: Close this PR and you won't be reminded about this update again.



This PR has been generated by Mend Renovate. View repository job log here.

BrianHenryIE commented 1 year ago

I think this should be "^0.7|^1.0".

the dealerdirect/phpcodesniffer-composer-installer package is an extremely popular package, 50+ million downloads, and I know personally I have many projects with ^0.7 pinned. If WooCommerce lists both ^0.7|^1.0 then all my projects continue getting the latest version of WooCommerce Sniffs. If just ^1.0 is used, then only the ones where I have * or ^1.0 for the dealerdirect package will get the newer WooCommerce Sniffs versions installed. Additionally, I presume other packages are likely to have ^0.7 pinned, and until they update their constraint, WooCommerce Sniffs will stick on its last version with ^0.7 set. Since WooCommerce Sniffs does work with the older dealerdirect package, I don't think it's incorrect to specify the version requirement like this. I'm not an expert on Composer version constraints, so I'm open to correction! I just saw where I could maybe save thousands of people making that tiny edit they might not notice they need to do.

https://woocommercecommunity.slack.com/archives/C4TNYTR28/p1683046094565389?thread_ts=1682997301.447649&cid=C4TNYTR28

JPry commented 1 year ago

I think this should be "^0.7|^1.0".

I think it's reasonable to use this as the parameter in this case. The breaking changes listed in the 1.0.0 release shouldn't impact people using these sniffs.

timnolte commented 1 year ago

Is there any ETA on this? Due to the package not allowing dealerdirect/phpcodesniffer-composer-installer v1 this is the sole package that is preventing me from upgrading.

renovate[bot] commented 1 year ago

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠ Warning: custom changes will be lost.

seebeen commented 1 year ago

Can someone merge this?

renovate[bot] commented 1 year ago

Autoclosing Skipped

This PR has been flagged for autoclosing. However, it is being skipped due to the branch being already modified. Please close/delete it manually or report a bug if you think this is in error.

ObliviousHarmony commented 1 year ago

This was updated in 3a65b917ff5ab5e65609e5dcb7bc62f9455bbef8