search

woocommerce / woocommerce-square

Square POS and Payments Integration
https://woo.com/products/square
Other
11 stars 7 forks source link

Release/4.6.3 #155

Closed dkotter closed 5 months ago

dkotter commented 5 months ago

Changes proposed in this Pull Request:

Version bump and prep for the 4.6.3 release

Closes #154

Steps to test the changes in this Pull Request:

Verify all file changes look accurate

dkotter commented 5 months ago

Tests are failing here and with the amount of changes in this release, would be great to get those fixed before we proceed with this release

vikrampm1 commented 5 months ago

@peterwilsoncc if you can help review the failed e2e tests here when you come online next week that would be great, so we can get this release out asap.

peterwilsoncc commented 5 months ago

Am I correct in thinking this is the diff for the release? https://github.com/woocommerce/woocommerce-square/compare/0d8387e93f22e94e046e078ac966bc4e3ac47456...a36b601a08f5a25d841214e46716ca521853b7c8

I'll look in to this in the mean time.

dkotter commented 5 months ago

Am I correct in thinking this is the diff for the release? https://github.com/woocommerce/woocommerce-square/compare/0d8387e93f22e94e046e078ac966bc4e3ac47456...a36b601a08f5a25d841214e46716ca521853b7c8

I believe that is correct, yes

iamdharmesh commented 5 months ago

Note: We already have PR raised with fixed tests https://github.com/woocommerce/woocommerce-square/pull/152.

However, some of newly added subscriptions related tests are failing in that PR, that is due to some subscriptions plugin setup issue in GH action. But existing tests are passing as expected.

dkotter commented 5 months ago

@iamdharmesh So seems like getting #152 finished up and merged in is the best next step here, does that sound correct? Just don't want to spend time fixing tests here if they've already been (mostly) fixed in that PR

iamdharmesh commented 5 months ago

@iamdharmesh So seems like getting https://github.com/woocommerce/woocommerce-square/pull/152 finished up and merged in is the best next step here, does that sound correct? Just don't want to spend time fixing tests here if they've already been (mostly) fixed in that PR

Yes, Correct @dkotter.