fix/143: Cancelling Google Pay on checkout shows validation errors

Sidsector9 commented 4 months ago

All Submissions:

[ ] Does your code follow the WooCommerce Sniffs variant of WordPress coding standards?
[ ] Have you written new tests for your changes, as applicable?
[ ] Have you successfully run tests with your changes locally?
[ ] Will this change require new documentation or changes to existing documentation?

Changes proposed in this Pull Request:

Closes #143

This PR does 2 things:

Fixes the issue #143
Refactors the implementation of Express Payment to align with other Woo gateways.

Steps to test the changes in this Pull Request:

Test Digital Wallets features.

Changelog entry

Fix - Cancelling Google Pay on checkout shows validation errors.

Sidsector9 commented 4 months ago

@peterwilsoncc I've fixed the issues you pointed, requesting a re-review.

qasumitbagthariya commented 3 months ago

QA Update ✅

I have verified this PR in the fix/143 branch has been fixed and is functioning as intended.

I tested the following on this branch:

Google Pay at checkout page ✅
Validation errors are not shown ✅

Testing Environment

- WordPress: 6.6.1 - Theme: Storefront 4.6.0 - Theme: Twenty Twenty-Four 1.2 - WooCommerce - 9.1.4 - PHP: 8.0.30 - Web Server: Nginx 1.20.2 - Browser: Chrome - OS: macOS Ventura 13.3 - Branch: fix/143

https://github.com/user-attachments/assets/0bfb9972-2be9-45fa-862f-4b8c80104300

Steps to Test- As mentioned in the PR description. Test Results - It is working as expected. Functional Demo / Screencast - Special Notes - Ready for code review (Woo) Testing Document status: Cases related to this Issue/PR are added to the Critical Flow Wiki pages:

[ ] Yes
[x] Not Required/Applicable for this PR

vikrampm1 commented 3 months ago

@Mayisha this PR is ready for your review!

qasumitbagthariya commented 3 months ago

Regression / Smoke Test Report ✅

Tested with Archive File created via "php woorelease.phar build repo_URL" (Composer version 2.5.5, npm version 8.19.4, node version 16.20.0)

Status- Working expected with Plugin Archive/Zip file same as fix specific branch.

Testing Environment

- WordPress: 6.6.1 - Theme: Storefront 4.6.0 - Theme: Twenty Twenty-Four 1.2 - WooCommerce - 9.1.4 - PHP: 8.0.30 - Web Server: Nginx 1.20.2 - Browser: Chrome - OS: macOS Ventura 13.3 - Branch: smoke-testing

Next Step- Ready to Merge 🚀

woocommerce / woocommerce-square