Closed dkotter closed 2 months ago
We have one failing E2E test here that needs looked at. I retried the tests a few times but that particular test failed each time
@iamdharmesh there is one failed E2E test here. Could you please review and fix it so we can unblock the release? Thanks.
The failing test is a newly added test in PR https://github.com/woocommerce/woocommerce-square/pull/72 (it is failing there as well). Checking on it.
While checking and fixing the tests, I noticed that the toggle for enabling/disabling stock management is not working in the new product editor. I'm not sure if this is related to the WC 9.2 updates. @Sidsector9 @qasumitbagthariya could you please help to check at your end to confirm the issue?
Thank you.
@iamdharmesh
I've cross-checked with different WooCommerce versions, 9.1.4 and 9.2.3, and confirmed the issue with version 9.2.3.
WooCommerce versions 9.1.4 ✅
https://github.com/user-attachments/assets/04b26124-217d-43a8-9bbc-2f265c8e26bb
WooCommerce versions 9.2.3 ⚠️
https://github.com/user-attachments/assets/ebb0242c-ba1b-4711-9122-82333e84a7ec
@qasumitbagthariya I have pushed fixes, can you check?
@Sidsector9 Thanks for the fix.
I've cross-checked with WooCommerce version 9.2.3, and enabling/disabling stock management is now working correctly with the new product editor.
I tested the following on this branch: stock management - new product editor ✅ stock management - Old product editor ✅
WooCommerce version 9.2.3
https://github.com/user-attachments/assets/ef56a03b-6e82-40ce-8692-e4b537a3742c
WooCommerce version 9.1.4
https://github.com/user-attachments/assets/0b5d379f-f8a6-4057-be51-4218b8d0acf5
@Sidsector9 @iamdharmesh Just following up on what is left to get this release unblocked? Seems E2E tests are still failing but looks like we fixed the other issue found but just wondering if there are other things that need addressed?
@dkotter I found that issue while investigating the root cause of the failing E2E tests and @Sidsector9 fixed the reported issue, but the E2E test action is still failing. I think it would be best to review and fix the E2E tests. @Sidsector9, Please let me know if you want me to check the E2E test failures here.
@iamdharmesh @dkotter I'll look into it tomorrow 👍
@dkotter the CashApp tests are failing on Woo 9.3.0-beta.1 but passes for Woo 9.2.3. (Couldn't figure out the reason)
@dkotter @vikrampm1 This is unblocked now.
@iamdharmesh I pushed a commit up to change the release date and tests are failing again 😢 Tried running them a couple times to see if it was just a flaky test but always failed
@iamdharmesh I pushed a commit up to change the release date and tests are failing again 😢 Tried running them a couple times to see if it was just a flaky test but always failed
@dkotter, this is a bit strange. I'm unable to download the artifact from the failure to determine the root cause, but in my latest commit, a few tests failed twice and are now passing (I tried two times: 1, 2)—and that’s without making any code changes. So, that seems flaky tests, I suspect this might be due to a sandbox issue. I noticed this message about degraded performance on the Square Discord. I’ll keep an eye on the tests for PRs to better understand the issue, but for now, I feel we’re good to proceed with the next steps here.
Changes proposed in this Pull Request:
Version bump and prep for the 4.8.0 release
Closes #203
Steps to test the changes in this Pull Request:
Verify all file changes look accurate