search

woocommerce / woocommerce-square

Square POS and Payments Integration
https://woo.com/products/square
Other
10 stars 4 forks source link

Gift Card image forced upon a site #30

Open ryanr14 opened 1 year ago

ryanr14 commented 1 year ago

Describe the bug

I've some feedback on the default Gift Card placeholder image. On a site, even if not using gift cards, you get the gift card placeholder image forced into your media library.

This has caused some merchants to worry there was a security issue on their site with a random image appearing. Especially since it's not clear from the image where it came from, and you can't delete it. That seems very suspicious from that perspective.

To reproduce

  1. Activate Square
  2. Look in media library
  3. See placeholder image

Screenshots

Screenshot 2023-09-12 at 12 17 31 PM

Expected behavior

I think there are two areas and things we could look to improve. First, If adding an image for a merchant, is there any way to make that clearer? Do we need explicit permission, or can we add more metadata to the image to make it clear where this came from?

Screenshot 2023-09-12 at 12 29 48 PM

Also, why can't the image being deleted. I mean, it can be deleted, but the linked to function above adds it right back. That seems to take away some control from the merchant, and can seem sketchy if you already don't know where this image is coming from.

jeffpaul commented 11 months ago

@ryanr14 that's great feedback, thanks for bringing that here from merchants. We'll look at this in two different areas: 1.) Better handling for only adding the image once its initially needed (versus immediately adding from an upgraded or newly installed Square version). 2.) Allowing for deletion of the image, which could break front-end views if someone is actually using gift cards on their site; but in this scenario that's a bit of "doing it wrong" for a merchant. However, allowing for the image to be deleted (and not immediately re-added back) would at least allow currently impacted merchants to remove the image.

ryanr14 commented 11 months ago

Thanks for hearing this feedback, @jeffpaul.

I understand it's hard to please everyone and find the solution that works well for the majority of folks. I think only adding the image if gift cards are used/enabled would be very helpful. At the least a store owner might be able to put two and two together to know why an image would be added. What about the option to even customize the gift card image? Just an extra thought, could someone upload and overwrite the default image with one branded for their store?

Maybe it works out well to create a gift card image field that works much like the Placeholder image setting in WooCommerce works?

mriyazuddin commented 10 months ago

@jeffpaul Wanted to mention that the ticket is open again and to know if a solution will be available soon. I'm placing the ticket on hold again in the meanwhile.

jeffpaul commented 10 months ago

@mriyazuddin there are 5 other large feature projects being worked on, so no this will not likely be resolved in the very near future

MariaChek commented 10 months ago

Just noting that the ticket number this was reported in is 6725287-zen. I will let the customer know that we don't have an estimation for when this will be changed, but we'll reach out to them once it is so that we can set expectations and close the ticket for now.

OmarFPG commented 6 months ago

7875446-zen

vikrampm1 commented 3 months ago

@Sidsector9 I am moving this back to To Do. Please review/pick it back up when you resume looking into this.

OmarFPG commented 3 months ago

8277030-zen, some images from Sucuri alerts were added to this ticket.