woocommerce / woocommerce-subscriptions-importer-exporter

Import your subscribers to WooCommerce from a CSV. Or export your subscription data from WooCommerce to CSV.
GNU General Public License v3.0
148 stars 56 forks source link

WC 4.4.1 Compatibility Bump #225

Closed chickenn00dle closed 3 years ago

chickenn00dle commented 4 years ago

This PR bumps the WC tested up to header to 4.4.1.

This also does the following:

I tested this with the latest versions of WC, WC Subs, and WC Memberships.

Closes #223

wigglemuff commented 4 years ago

@chickenn00dle This LGTM. However, the Travis CI build fails.

$ bash tests/bin/install.sh wcsie_test root '' localhost $WP_VERSION

0.70s$ bash tests/bin/travis.sh before

WooCommerce Installed

Cloning into '../woocommerce-subscriptions'...

remote: Repository not found.

fatal: repository 'https://[secure]@github.com/Prospress/woocommerce-subscriptions.git/' not found

The command "bash tests/bin/travis.sh before" failed and exited with 128 during .

I think we'll need to fix the subscriptions repo URL here: https://github.com/woocommerce/woocommerce-subscriptions-importer-exporter/blob/master/tests/bin/travis.sh. I'll do it and see if that helps.

LukeAbell commented 3 years ago

@codestor4 @chickenn00dle can you get this merged?

wigglemuff commented 3 years ago

I did a rebase of this with master with the hope that these changes would help fix the Travis build issue.

Travis build still fails but for other reasons (PHPCS issues).

We can fix PHPCS issues in a separate PR. I'll go ahead and merge this now!

LukeAbell commented 3 years ago

Thank you!!