Closed wigglemuff closed 3 years ago
Asked for some help in the team channel: p1603558689262000-slack-CJTS771PB
@codestor4 The tests were running on travis-ci.org and the Travis ENV variable GITHUB_TOKEN was invalid (Github Personal Access Token, which might have revoked).
To update the Token, I've migrated the repo to travis-ci.com and added a new Personal Access Token to the ENV variable. Now Travis can clone WCS successfully and the builds are running as expected.
I've removed the conditional code you've added since Token is required to clone WCS
Ok so the only change we're making here is updating the org from prospress
to woocommerce
and moving the git clone
code outside of the before script
. I still see "all checks have failed" but I believe all should be well once we merge, is that right @achyuthajoy?
Hey @codestor4 The tests are running as expected. Cloning WCS is successful and the Unit Tests were successful. However, the build failed since PHPCS reported a lot of errors.
Ok so the only change we're making here is updating the org from prospress to woocommerce and moving the git clone code outside of the before script.
It's fine to move git clone back the the before condition. I think I've missed it while pushing changes, which I've fixed. Basically the only change is to update the repo link and a bit of refactoring.
LGTM 👍 Merging
Updating it from
Prospress/woocommerce-subscriptions
towoocommerce/woocommerce-subscriptions
.Why? Because currently the build fails and this fix should hopefully get the build to complete without any errors.
Edit: While I wait for the build to complete, I'm not sure whether my changes would work for a private wcs repository. Let's see!