Open nigeljamesstevenson opened 1 year ago
More context: https://github.com/woocommerce/woocommerce/pull/37845 fixed the issue but only for the non-HPOS case.
Thanks for bringing the attention to my explanation here. There's a whole revamp of hooks needed here.
Hopefully this gets addressed.
Prerequisites
Describe the bug
This bug was discovered as part of Internal Testing WC7.8 - the link to the Internal Testing PR where the bug was discovered is here
When a product and an order is created and a hook is applied to add fees to the order, the order totals do not appear as expected when HPOS is enabled (see below):
The totals appear fine when HPOS is disabled.
Additional information can be found on this comment
Expected behavior
For HPOS, when a product and an order is created and a hook is applied to add fees to the order, the Order totals should appear correctly on entry to the screen without the need to click
Update
buttonActual behavior
When HPOS is enabled, Order totals do not appear correctly on entry to the Orders screen when a product and an order is created and a hook is applied to add fees to the order. Note - If the Update button is clicked then the totals are updated as expected
Steps to reproduce
This bug was discovered as part of Internal Testing WC7.8
Steps to recreate are listed here
Additional information can be found on this comment
WordPress Environment
`
WordPress Environment
WordPress address (URL): https://grand-squid.jurassic.ninja Site address (URL): https://grand-squid.jurassic.ninja WC Version: 7.8.0 REST API Version: ✔ 7.8.0 WC Blocks Version: ✔ 10.2.0 Action Scheduler Version: ✔ 3.5.4 Log Directory Writable: ✔ WP Version: 6.2.2 WP Multisite: – WP Memory Limit: 256 MB WP Debug Mode: ✔ WP Cron: ✔ Language: en_US External object cache: –
Server Environment
Server Info: Apache/2.4.57 (Unix) OpenSSL/1.0.2g PHP Version: 7.4.33 PHP Post Max Size: 1 GB PHP Time Limit: 30 PHP Max Input Vars: 5000 cURL Version: 7.47.0 OpenSSL/1.0.2g
SUHOSIN Installed: – MySQL Version: 5.7.33-0ubuntu0.16.04.1-log Max Upload Size: 512 MB Default Timezone is UTC: ✔ fsockopen/cURL: ✔ SoapClient: ✔ DOMDocument: ✔ GZip: ✔ Multibyte String: ✔ Remote Post: ✔ Remote Get: ✔
Database
WC Database Version: 7.8.0 WC Database Prefix: wp_ Total Database Size: 5.12MB Database Data Size: 3.37MB Database Index Size: 1.75MB wp_woocommerce_sessions: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_woocommerce_api_keys: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_woocommerce_attribute_taxonomies: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_woocommerce_downloadable_product_permissions: Data: 0.02MB + Index: 0.06MB + Engine InnoDB wp_woocommerce_order_items: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_woocommerce_order_itemmeta: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_woocommerce_tax_rates: Data: 0.02MB + Index: 0.06MB + Engine InnoDB wp_woocommerce_tax_rate_locations: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_woocommerce_shipping_zones: Data: 0.02MB + Index: 0.00MB + Engine InnoDB wp_woocommerce_shipping_zone_locations: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_woocommerce_shipping_zone_methods: Data: 0.02MB + Index: 0.00MB + Engine InnoDB wp_woocommerce_payment_tokens: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_woocommerce_payment_tokenmeta: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_woocommerce_log: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_actionscheduler_actions: Data: 0.02MB + Index: 0.11MB + Engine InnoDB wp_actionscheduler_claims: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_actionscheduler_groups: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_actionscheduler_logs: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_commentmeta: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_comments: Data: 0.02MB + Index: 0.09MB + Engine InnoDB wp_links: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_options: Data: 2.22MB + Index: 0.06MB + Engine InnoDB wp_postmeta: Data: 0.05MB + Index: 0.03MB + Engine InnoDB wp_posts: Data: 0.05MB + Index: 0.06MB + Engine InnoDB wp_snippets: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_termmeta: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_terms: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_term_relationships: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_term_taxonomy: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_usermeta: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_users: Data: 0.02MB + Index: 0.05MB + Engine InnoDB wp_wc_admin_notes: Data: 0.06MB + Index: 0.00MB + Engine InnoDB wp_wc_admin_note_actions: Data: 0.05MB + Index: 0.02MB + Engine InnoDB wp_wc_category_lookup: Data: 0.02MB + Index: 0.00MB + Engine InnoDB wp_wc_customer_lookup: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_wc_download_log: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_wc_orders: Data: 0.02MB + Index: 0.11MB + Engine InnoDB wp_wc_orders_meta: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_wc_order_addresses: Data: 0.02MB + Index: 0.06MB + Engine InnoDB wp_wc_order_coupon_lookup: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_wc_order_operational_data: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_wc_order_product_lookup: Data: 0.02MB + Index: 0.06MB + Engine InnoDB wp_wc_order_stats: Data: 0.02MB + Index: 0.05MB + Engine InnoDB wp_wc_order_tax_lookup: Data: 0.02MB + Index: 0.03MB + Engine InnoDB wp_wc_product_attributes_lookup: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_wc_product_download_directories: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_wc_product_meta_lookup: Data: 0.02MB + Index: 0.09MB + Engine InnoDB wp_wc_rate_limits: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_wc_reserved_stock: Data: 0.02MB + Index: 0.00MB + Engine InnoDB wp_wc_tax_rate_classes: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_wc_webhooks: Data: 0.02MB + Index: 0.02MB + Engine InnoDB wp_wp_phpmyadmin_extension__errors_log: Data: 0.02MB + Index: 0.02MB + Engine InnoDB
Post Type Counts
attachment: 1 page: 7 post: 2 product: 1 shop_order: 12
Security
Secure connection (HTTPS): ✔ Hide errors from visitors: ❌Error messages should not be shown to visitors.
Active Plugins (7)
JSON Basic Authentication: by WordPress API Team – 0.1 Code Snippets: by Code Snippets Pro – 3.4.0 Companion Plugin: by Osk – 1.29 Jetpack: by Automattic – 12.1 WooCommerce Beta Tester: by WooCommerce – 2.2.0 WooCommerce: by Automattic – 7.8.0-beta.1 WP phpMyAdmin: by Puvox.software – 5.2.1.02
Inactive Plugins (2)
Akismet Anti-Spam: Spam Protection: by Automattic - Anti Spam Team – 5.1 Hello Dolly: by Matt Mullenweg – 1.7.2
Settings
API Enabled: – Force SSL: – Currency: USD ($) Currency Position: left Thousand Separator: , Decimal Separator: . Number of Decimals: 2 Taxonomies: Product Types: external (external) grouped (grouped) simple (simple) variable (variable)
Taxonomies: Product Visibility: exclude-from-catalog (exclude-from-catalog) exclude-from-search (exclude-from-search) featured (featured) outofstock (outofstock) rated-1 (rated-1) rated-2 (rated-2) rated-3 (rated-3) rated-4 (rated-4) rated-5 (rated-5)
Connected to WooCommerce.com: – Enforce Approved Product Download Directories: ✔ HPOS feature screen enabled: ✔ HPOS feature enabled: – Order datastore: WC_Order_Data_Store_CPT HPOS data sync enabled: ✔
WC Pages
Shop base: #5 - /shop/ Cart: #6 - /cart/ Checkout: #7 - /checkout/ My account: #8 - /my-account/ Terms and conditions: ❌ Page not set
Theme
Name: Twenty Twenty-Three Version: 1.1 Author URL: https://wordpress.org Child Theme: ❌ – If you are modifying WooCommerce on a parent theme that you did not build personally we recommend using a child theme. See: How to create a child theme WooCommerce Support: ✔
Templates
Overrides: –
Admin
Enabled Features: activity-panels analytics product-block-editor coupons customer-effort-score-tracks import-products-task experimental-fashion-sample-products shipping-smart-defaults shipping-setting-tour homescreen marketing mobile-app-banner navigation onboarding onboarding-tasks remote-inbox-notifications remote-free-extensions payment-gateway-suggestions shipping-label-banner subscriptions store-alerts transient-notices woo-mobile-welcome wc-pay-promotion wc-pay-welcome-page
Disabled Features: core-profiler minified-js new-product-management-experience product-variation-management settings async-product-editor-category-field
Daily Cron: ✔ Next scheduled: 2023-05-30 15:18:21 +00:00 Options: ✔ Notes: 69 Onboarding: -
Action Scheduler
Complete: 32 Oldest: 2023-05-26 15:20:19 +0000 Newest: 2023-05-30 09:17:13 +0000
Failed: 1 Oldest: 2023-05-26 15:23:38 +0000 Newest: 2023-05-26 15:23:38 +0000
Pending: 1 Oldest: 2023-05-31 07:10:49 +0000 Newest: 2023-05-31 07:10:49 +0000
Status report information
Generated at: 2023-05-30 09:34:21 +00:00 `
Isolating the problem