Open vivialice opened 2 years ago
For now, we will not work on this issue. Our goal is to have the blockified Single Page template. In this way, we will be able to provide consistent behavior for the Mini Cart block.
I will not close this issue. Consider it as a reminder.
I like the ultimate goal of the blockified Single Page template! In the interim though it feels like the notification "XYZ item has been added to your cart." should still appear if you have the mini-cart added to your navigation. Right now it feels broken and the user has very little way to know what happened (other than of course the change to the mini-cart values in the nav).
This issue has been marked as stale
because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.
I like the ultimate goal of the blockified Single Page template! In the interim though it feels like the notification "XYZ item has been added to your cart." should still appear if you have the mini-cart added to your navigation. Right now it feels broken and the user has very little way to know what happened (other than of course the change to the mini-cart values in the nav).
Thanks for sharing your feedback. There is a dedicated issue for this (#6621).
This issue has been marked as stale
because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.
Adding a +1 to note that we ran into this issue using the Mini Cart block on a Team51 site as well, and it wasn't clear that the mini cart not expanding on single product pages when items are added was the expected behavior.
A small note in the block or documentation explaining where this does/doesn't work may be helpful while we wait for the blockified templates.
@Aljullu does the estimate (8) refer to opening the drawer on the product page or another solution?
Yes, this was a tricky one. Currently the Add to Cart button on the Single Product page causes a page refresh, that's why we can't open the Mini Cart drawer on addition. To solve this, we should refactor the logic in WC core so adding to cart from the Single Product page doesn't require a page refresh. After that, making the Mini Cart block open automatically should be fairly easy.
The 8
story points of the estimate should include everything. But I didn't do an in-depth investigation before estimating and considering this needs to be fixed in WC core instead of WC Blocks, I would label this as COU 5, so the estimate is likely not to be very accurate.
Thanks for the clarification. It would be good to do an investigation to reduce the COU and then evaluate if it makes sense to move forward with this.
Sorry for the delay answering. I just found out that WC core already has an issue for this: https://github.com/woocommerce/woocommerce/issues/36006. IMO, it makes more sense to work on this in the context of WC core instead of WC Blocks because:
So as the way forward:
Please let me know if that doesn't look good! :slightly_smiling_face:
Yes, thanks!
Who will solve the Core issue? Origami/Kirigami or the Platform team?
Who will solve the Core issue? Origami/Kirigami or the Platform team?
I don't know! :slightly_smiling_face: I think both teams would be good candidates to work on this, so it just depends on prioritization.
I see this issue and I think the problem is that currently, the Add to cart form block doesn't support Ajax. That's why, when clicking on add to cart, the page is refreshed. If you install a plugin like Ajax add to cart for WooCommerce, when clicking on Add to cart, the page won't reload, the product will be added to the cart and the mini cart will slide in from the left just fine.
@pmcpinto, I think this should be tackled by core product teams (not platform) and assessed for priority. IMO it's important to bring consistent behaviour across all instances of the Add to Cart button (especially in a block environment).
Good point. Which Core team is the best suited to handle this implementation? cc @chrisdesrochers
Either of Rubik, Kirigami, or Origami. There's overlap for all the teams. It'd probably be good for Origami or Kirigami given their ownership over the Mini Cart block and the connection with that behaviour.
Describe the bug
I have the setting to: "open drawer" when item is added. This works fine on the product grid but when I test it on the single product page, the drawer doesnt open. I've recorded a quick video.
To reproduce
Steps to reproduce the behavior:
Expected behavior
Drawer should open any time add to cart button is pressed when this setting is selected.
Screenshots
https://user-images.githubusercontent.com/9888201/160683218-0c16340e-894c-4005-bad5-3c72fdc655f9.mov
Environment
WordPress (please complete the following information):
Desktop (please complete the following information):