Fields using incorrect IDs in the Product Block Editor

woocommerce / woocommerce

A customizable, open-source ecommerce platform built on WordPress. Build any commerce solution you can imagine.

https://woocommerce.com

9.22k stars 10.74k forks source link

Fields using incorrect IDs in the Product Block Editor #46659

Open Rahmon opened 2 months ago

Rahmon commented 2 months ago

The IDs of the fields Hide in product catalog and Hide from search results are inverted:

Hide in product catalog
- id: product-catalog-search-visibility
Hide from search results
- id: product-catalog-catalog-visibility

https://github.com/woocommerce/woocommerce/blob/trunk/plugins/woocommerce/src/Internal/Features/ProductBlockEditor/ProductTemplates/SimpleProductTemplate.php#L456

mattsherman commented 2 months ago

@Rahmon This actually appears correct to me, if a bit confusing. The UX in the new product editor is using the "hide" case, so these are flipped a bit from what you'd expect. But, you see that the visibility attribute is set correct on each block.

Please let me know and provide detailed reproduction steps if you still believe this to be incorrect.