woocommerce / woocommerce

A customizable, open-source ecommerce platform built on WordPress. Build any commerce solution you can imagine.
https://woocommerce.com
9.32k stars 10.75k forks source link

Add specific aria-label for different actions on the Orders table #51404

Open Manussakis opened 3 days ago

Manussakis commented 3 days ago

Prerequisites

Describe the bug

All three buttons on the Orders table (Pay, View, and Cancel) have the same aria-label attribute, so users can't tell apart the action each one executes.

This issue was introduced once the https://github.com/woocommerce/woocommerce/pull/49424 PR was merged.

Expected behavior

The Pay button with the aria-label "Pay order number {...}" The View button with the aria-label "View order number {...}" The Cancel button with the aria-label "Cancel order number {...}"

Actual behavior

Pay, View, and Cancel buttons have the "View order number {...}" aria-label.

Steps to reproduce

  1. Create an order with the "Pending payment" status.
  2. On the frontend, go to My Account -> Orders.
  3. Turn on the screen reader and land the focus on each one of the Pay, View, and Cancel buttons. image
  4. Verify the screen reader announces the same message for all of them: "View order number {...}"

WordPress Environment

WC version 9.3.1 WP version 6.6.2 Theme Twenty Twenty-Four version 1.2

Isolating the problem

christopher-bio commented 3 days ago

Thank you very much @Manussakis ! :)