woodcrafty / PyETo

Python package for calculating reference/potential evapotranspiration (ETo).
BSD 3-Clause "New" or "Revised" License
155 stars 81 forks source link

incorrect conversion of wind speed: used log instead of ln #12

Closed jeroenterheerdt closed 3 years ago

jeroenterheerdt commented 3 years ago

at this line in the wind_speed_2m() function log is used instead of ln: https://github.com/woodcrafty/PyETo/blob/0b7ac9f149f4c89c5b5759a875010c521aa07f0f/pyeto/fao.py#L735

It should be LN since the value at 2m should be lower than at a higher altitude... https://www.researchgate.net/post/Is-that-possible-to-convert-wind-speed-measured-in-10-m-height-to-a-possible-2-m-height-wind-speed#:~:text=If%20the%20measurement%20is%20made%20at%2010%20m,if%20your%20measurement%20is%20at%20height%20z%20%28uz%29

jeroenterheerdt commented 3 years ago

never mind, turns out math.log is actually the ln if only one parameter is provided.