woodenshoe-wi / rox-filer

Special version for woof-CE
0 stars 0 forks source link

Menu actions on single core machines #3

Open woodenshoe-wi opened 5 years ago

woodenshoe-wi commented 5 years ago

@ninaholic reported some irregularities with the menu.

https://github.com/puppylinux-woof-CE/woof-CE/pull/1467#issuecomment-505514900

After investing I found that I could reproduce the problem on my raspi 1 (which is a single core) but not on my raspi 3 (which is a quad core). Since my PC also has a quad core CPU this issue went mostly unnoticed as a strange quirk that only affected a slow Raspberry Pi.

After running git bisect on the affected raspi I was able to track down the commit that introduced the problem 46204b6 which was dealing with the clipboard but caused ROX to have to wait for itself to get the clipboard info.

The bug got merged into jun7’s rox-filer along with the clipboard functionality, and JakeSFR discovered it and reported it to jun7 who fixed it.

I cherrypicked jun7’s fix, b40ef8c but have not made pets so I will leave this issue open for now.

ghost commented 5 years ago

Thanks woodenshoe!

I tried to compile your source in slacko 14.0 (using first method) and it worked, and the right-click action seems to work on first attempt again :smile_cat: Here was my compile attempt if you want it

http://s000.tinyupload.com/index.php?file_id=30846436957073857817

woodenshoe-wi commented 5 years ago

Thanks for confirming that it actually is fixed.