Closed sammcj closed 4 years ago
Hey @sammcj
If you could rename RUNNER_REGISTER_PARAMS
to ADDITIONAL_REGISTER_PARAMS
I'd be happy to merge. I think it just helps clarify that there are some params already configured in the image.
For now, remove the changes to the readme and the default --machine-machine-options amazonec2-use-private-address=true
as I've got some proposed changes over at #2
Hi @woodjme,
Thanks for reviewing this, I've made your suggested changes to the MR.
amazonec2-use-private-address=true
which then allows you to lock down the security group and mitigates https://github.com/woodjme/autoscaling-ec2-gitlab-runners-fargate/issues/2--tag-list mytag
to register the runner with a specific ci tag. (fixes https://github.com/woodjme/autoscaling-ec2-gitlab-runners-fargate/issues/1)