woodjme / autoscaling-ec2-gitlab-runners-fargate

Autoscaling EC2 GitLab Runners Spawned by Fargate
MIT License
19 stars 7 forks source link

Allow optional runner register params, bump machine version #3

Closed sammcj closed 4 years ago

sammcj commented 4 years ago
woodjme commented 4 years ago

Hey @sammcj

If you could rename RUNNER_REGISTER_PARAMS to ADDITIONAL_REGISTER_PARAMS I'd be happy to merge. I think it just helps clarify that there are some params already configured in the image.

For now, remove the changes to the readme and the default --machine-machine-options amazonec2-use-private-address=true as I've got some proposed changes over at #2

sammcj commented 4 years ago

Hi @woodjme,

Thanks for reviewing this, I've made your suggested changes to the MR.