Support other OS than Debian ones

woodpecker-ci / autoscaler

Scale your woodpecker agents automatically to the moon and back based on the current load.

Apache License 2.0

29 stars 5 forks source link

Support other OS than Debian ones #165

Closed pat-s closed 1 week ago

pat-s commented 2 weeks ago

Currently the installation of docker is hardcoded to apt-based distributions: https://github.com/woodpecker-ci/autoscaler/blob/88577b83ea0ccaa3d53a6c9acf61392c8b16f471/engine/const.go#L24-L29

anbraten commented 2 weeks ago

What would be your usecase for some other os? I think you can provide a custom cloud-init template in case you have a custom requirement.

pat-s commented 2 weeks ago

I just prefer rhel-based ones over debian-based ones.

There is already WOODPECKER_HETZNERCLOUD_IMAGE which is only limited to a few options due to the mentioned restrictions.

Ideally, the correct cloud-init template would be chosen based on the selected WOODPECKER_HETZNERCLOUD_IMAGE.

xoxys commented 2 weeks ago

I don't think we should add built-in cloud-init templates for multiple distributions. As anbraten said, It's already possible to overwrite the cloud-init templates by users, why not just use it?

pat-s commented 1 week ago

Fair enough, didn't see that this was configurable. Thanks @xoxys!