Closed allanger closed 9 months ago
appVersion
must be inferred from the upstream WP version and this lookup is automated within the release process. We don't want to change it manually every time. The automation is working fine, we just need to fix the 'v' prefix.
There will be a new release soon, please adjust manually until then :)
Alright, good to know. Though I don't see why would you be changing it manually every time with my PR :)
The PR won't have an effect until a new release for users (unless a few use helm-git
) and the next one is a major one due to some restructuring so we can't release it immediately either. And if we would do a release, it would anyhow be done by the release automation.
When the image tag is not defined in Values, it's using the appVersion from the chart definition, though there is no such tag in the default container registry, because images there have the 'v' prefix.
In this commit, I'm setting the default image tag to be prefixed with 'v' in case it's not provided via Values