search

woodpecker-ci / helm

This repo contains the helm charts of the Woodpecker project.
Apache License 2.0
21 stars 17 forks source link

fix woodpecker_server to work out of the box #75

Closed ashtonian closed 1 year ago

ashtonian commented 1 year ago

fixes #74

ashtonian commented 1 year ago

Thanks for looking at it. It works if they are in the same namespace, https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/, within the namespace its the same as a hostname lookup where the service woodpecker-server is the hostname and the domain .{namespace}.svc.cluster.local gets appended automatically with each dns query. You therefore only need the fqdn when going outside the namespace.

pat-s commented 1 year ago

Makes sense, thanks for the explanation.

We had split charts for a long time and user were often deploying into separate namespaces therefore. But now with the umbrella chart the namespace is the same, so this change could remove the explicit definition by users.

So yeah I see how this change would simplify things. Any objections @anbraten?

anbraten commented 1 year ago

Sounds fine to me

ashtonian commented 1 year ago

🎉 Thanks!

woodpecker-bot commented 11 months ago

🎉 This PR is included in version 0.4.0 🎉

The release is now available here

Thank you for your contribution. ❤️📦🚀