search

woodpecker-ci / helm

Woodpecker CI Helm Charts
Apache License 2.0
23 stars 17 forks source link

allow `extraVolumeMounts` without enabling default persistentVolume #97

Closed pat-s closed 1 year ago

pat-s commented 1 year ago

_Originally posted by @genofire in https://github.com/woodpecker-ci/helm/pull/94#discussion_r1358218931_

pat-s commented 1 year ago

Might be a false-positive

genofire commented 1 year ago

This should be open again, still not fixed.

till volumeMount: is outside of the if .Values.persistent.enabled

genofire commented 1 year ago

just try:

helm template --debug . -f broken-values.yaml

with this broken-values.yaml:

server:
  resources:
    requests:
      cpu: "500m"
      memory: "200m"
  persistentVolume:
    enabled: false
  extraVolumes:                                                                                                                                                                                                                                                                                              
    - name: docker-config
      configMap:
        name: docker-config
  extraVolumeMounts:
    - name: docker-config
      mountPath: /etc/docker