search

woodpecker-ci / plugin-surge-preview

Apache License 2.0
2 stars 3 forks source link

unmaintained dep "surge" #13

Closed 6543 closed 3 days ago

6543 commented 1 year ago

https://github.com/sintaxi/surge looks unmaintained

pat-s commented 8 months ago

Is there an alternative? Do we even want to continue this plugin if the underlying base is unmaintained? We risk introducing CVEs to users potentially.

qwerty287 commented 8 months ago

Afaik there's no free alternative. Means we either have to pay for a service (e.g. netlify) or we host something our own.

pat-s commented 8 months ago

If the main purpose of the plugin is for PR preview of websites, there are many alternatives: using gh-pages, using S3 buckets, using codeberg pages.

Lately, there was already a request for a plugin to easily use codeberg-pages (https://codeberg.page/). Maybe there could be one plugin which let's users decide between gh-pages and cb-pages dynamically?

qwerty287 commented 8 months ago

Yes, that would be possible, but it also has some issues because we use a new subdomain for every PR. Using gh/cb pages we could still solve this by using separate directories, but that involve much more code in comparison to the current solution with surge (and subdomains "look" more clean I think).

pat-s commented 8 months ago

I think for previews nobody cares about the final URL (which is why I also like to use http-only S3 URLs). I agree that it would be great to stay with surge as it (still) works and does it's job, but if the maintenance doesn't continue, we need to find a solution for this at some point (either for security or because it will break at some point).

pat-s commented 8 months ago

Speaking of it: https://codeberg.org/Codeberg-CI/examples/pulls/35

qwerty287 commented 8 months ago

Even though the repo seems unmaintained: If you take a look at the issues, the maintainer (sintaxi) still responds to them.