Terminal issues

[anbraten]

Component

web-ui

Describe the bug

I noticed some issues with the new terminal:

• log lines for other running jobs shown in selected running jobs? 🤔 or the terminal is not properly reset after switching
• space reserved for exit code x for running jobs (Screenshot 1)
• exit code x pushed to bottom (only half of it visible) (Screenshot 2)
• sometimes it still seems to flicker

System Info

{"source":"https://github.com/woodpecker-ci/woodpecker","version":"next-3f73d5bf"}

Additional context

No response

Validations

• [X] Read the Contributing Guidelines.
• [X] Read the docs.
• [X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• [X] Check that this is a concrete bug. For Q&A join our Discord Chat Server or the Matrix room.

[qwerty287]

I also noticed on mobile, if I click into the terminal area, my keyboard appears, but I can't type anything (obviously).

[thestr4ng3r]

log lines for other running jobs shown in selected running jobs? 🤔 or the terminal is not properly reset after switching

I think this always happens while the job is still running, when it is streaming the log in realtime rather than just fetching it statically.

For our instance, we have switched to using xterm's dom renderer instead of the canvas-based one since the canvas one feels unresponsive to me when scrolling (always a bit delayed): https://github.com/rizinorg/woodpecker/commit/6146b70e5f858643532078052570aeae6ca0cb51#diff-a381d47772869b92cbbfb7b65a6e4222af8629b6a0b5fd5ba7db7e12dd5bff4aR102 This generates a lot of dom, but might be worth trying out too.

[qwerty287]

1. The green Exit-Code 0 is not good visible in light mode.
2. Also https://github.com/woodpecker-ci/woodpecker/issues/998