woodpecker-ci / woodpecker

Woodpecker is a simple, yet powerful CI/CD engine with great extensibility.
https://woodpecker-ci.org
Apache License 2.0
4.07k stars 353 forks source link

JSON schema out of date #2020

Closed lonix1 closed 1 year ago

lonix1 commented 1 year ago

Component

other

Describe the bug

Since https://github.com/woodpecker-ci/woodpecker/issues/1948 was fixed (yesterday), the json schema for .woodpecker.yml is out of date, but that issue was locked so I can't comment there.

This is possible so that the logs show "clone" (as it was before the fix) instead of "git":

clone:
  clone:           # can be any word: "clone", "git" or whatever
    image: woodpeckerci/plugin-git:2.0.3
steps:
  build:
    # ...

But the schema only allows "git". If I use "clone" then I get an error in vscode: Property clone is not allowed..

I couldn't submit a PR because I'm unsure how to fix it - I can't just change "git" to "clone" as both are valid, as well as any other word.

(I'm willing to try fixing it if someone has an idea how to specify "any word"?)

System Info

version next
vscode

Additional context

No response

Validations

6543 commented 1 year ago

2063

lonix1 commented 1 year ago

If I understand correctly, that one seems to be about links which are out of date.

This one is about a schema change due to a code change.

Is it really a dupe?

6543 commented 1 year ago

Well I'm not aware of how we should version tje schemastore ... so it can only bee about making sure it's about latest stable ...

lonix1 commented 1 year ago

Ok thanks. I will add the above use case to the other issue then.