Enabling repository results in: pq: duplicate key value violates unique constraint "UQE_orgs_name" #2922

Open simmstein opened 9 months ago

Component

server

Describe the bug

Hello,

Encountered an issue when attempting to add a new repository from a GitLab instance hosted on-premise. The error message received is as follows: pq: duplicate key value violates unique constraint "UQE_orgs_name". It works once time but I was the only one developer linked to this organization. Now we are more.

Context: The GitLab setup involves multiple organizations, and the bug manifests when trying to add a repository of the second organization.

Should be linked to #2092

We are owners of the organization.

System Info

Version: next-adb2c82790
Forge: Gitlab (on premise)
Deployment: docker swarm

Additional context

Good	Not good

Server log:

***redacted***_woodpeckerci_woodpecker-server.1.y8k5453nahp3@***redacted***    | {"level":"debug","ip":"***redacted***","latency":594.416323,"method":"POST","path":"/api/repos","status":500,"time":"2023-12-08T08:57:53Z","user-agent":"Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/119.0","time":"2023-12-08T08:57:53Z","caller":"/woodpecker/src/github.com/woodpecker-ci/woodpecker/server/router/middleware/logger.go:59"}

Validations

[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Checked that the bug isn't fixed in the next version already [https://woodpecker-ci.org/faq#which-version-of-woodpecker-should-i-use]
[X] Check that this is a concrete bug. For Q&A join our Discord Chat Server or the Matrix room.

Can you check the content of your DB? What's the data in the orgs.org_name column?

It's sysadmin/sub-group. By renaming to sysadmin, it seems to work back but it's strange.

That sounds link an issue with sub-groups. I will try to give it a look

I don't if another commit fix this error but after upgrading to the latest version, It seems to work now.

I'm currently having this issue (I'm on the latest in the nixpkgs, v2.5.0). I also noticed that:

Clicking on the Org in the header bar of a repo brings me to the wrong Org (ie. If I'm in the project org-name/project-name and click on the org-name in the header, it sends me to org-name/different-sub-group instead of org-name. The subgroup does exist in the repo but the project isn't in it)
Secrets set on the above org are not accessible in the project, presumably because they're actually stored for org-name/subgroup and not org-name
The only org name in the sqlite orgs table is set to org-name/subgroup even though the only repo added is in org-name not org-name/subgroup

Update: It appears that manually changing the database row does solve the issue. After modifying the row and adding the second repo, it appears the new repo is using the correct org as well

woodpecker-ci / woodpecker