woodpecker-ci / woodpecker

Woodpecker is a simple, yet powerful CI/CD engine with great extensibility.
https://woodpecker-ci.org
Apache License 2.0
4.18k stars 360 forks source link

Update notice showing for v2.1.0 while already on v2.1.0 #3034

Closed kemitix closed 9 months ago

kemitix commented 9 months ago

After switching to the v2.1.0 docker image for woodpecker, the admin interface says to update to the current version.

image

This is from the docker image: woodpeckerci/woodpecker-server:v2.1.0

anbraten commented 9 months ago

https://woodpecker-ci.org/version.json is having the v-prefix. So we either need to strip it when updating in ci or use string-replace in UI.

awnion commented 9 months ago

Similar in case of the woodpeckerci/woodpecker-server:next container:

Screenshot 2023-12-27 at 11 18 28

But the "recommended" version doesn't exist!

Screenshot 2023-12-27 at 11 21 28
6543 commented 9 months ago

I'll create a hotfix, and we should do semversion parsing wo compares versions

kemitix commented 9 months ago

Thanks. Everything looks great now.