`docker run woodpeckerci/woodpecker-cli setup` tries to run xdg-open to spawn a web browser

wez commented 5 months ago

Component

cli

Describe the bug

The docker version of the CLI wants to spawn a web browser via a launcher of some kind, which will always fail in the context of docker, because the image cannot include a browser.

Steps to reproduce

$ docker run --rm -it woodpeckerci/woodpecker-cli setup --server-url https://some.host
1:01AM FTL error running cli error="exec: \"xdg-open\": executable file not found in $PATH"

Expected behavior

Rather than raising an error for the not-found case, this logic:

https://github.com/woodpecker-ci/woodpecker/blob/964860434c7548b73778476bf64125e6713d6b0a/cli/setup/token_fetcher.go#L115-L124

could print the URL to stdout so that the user can click on it, or copy and paste it to open it that way. That would also help in the "unsupported platform" case.

System Info

$ docker run --rm woodpeckerci/woodpecker-cli --version
woodpecker-cli version 2.5.0

Additional context

No response

Validations

[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Checked that the bug isn't fixed in the next version already [https://woodpecker-ci.org/faq#which-version-of-woodpecker-should-i-use]

wez commented 5 months ago

If I bypass that by running setup with --token, the next thing I run into is:

https://github.com/woodpecker-ci/woodpecker/issues/3739

wez commented 5 months ago

I realize that I probably also need to map a volume to capture whatever state setup is setting up, but it's a bit of a moot point at the moment! :-)

wez commented 5 months ago

I had to go back to v2.3.0 to be able to use the CLI:

$ docker run --rm -it woodpeckerci/woodpecker-cli:v2.3.0-alpine --server $WOODPECKER_SERVER --token $WOODPECKER_TOKEN user ls

all subsequent versions are unusable due to external dependencies.

woodpecker-ci / woodpecker