Closed 6543 closed 1 week ago
Attention: Patch coverage is 0%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 26.50%. Comparing base (
402938e
) to head (2f0f9fe
).:exclamation: Current head 2f0f9fe differs from pull request most recent head e484bdd
Please upload reports for the commit e484bdd to get more accurate results.
Files | Patch % | Lines |
---|---|---|
server/pipeline/create.go | 0.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I don't get how this can change something.
I checked all usages of Create
and they just check err != nil
and if there's an error, the returned pipeline itself is not used.
Besides that, I don't think it should return a 200 to the webhook. Yes, 500 is bad too, but something like 400?
juts test it ... update a pipeline definition to an invalid format ... e.g. non valid json
Before you got an 500 ... now you get 200
An other status is fine by me too but not 500
Tearing down https://woodpecker-ci-woodpecker-pr-3829.surge.sh
Instead of show in e.g. gitea a 500, we get an 200 response and the actual pipeline info
this helps to debug and easyer to integrate ...